Skip to content

RFC Implement generic ASoC HDMI codec

Jyri Sarha alsa-devel dri-devel linux-omap 2 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest7 patches 5 repliesApplied
  2. v1 RFC2 patches 2 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/7ASoC: core: If component doesn't have of_node use parent's node insteadsound/soc/soc-core.c+12 -21 reply
2/7ASoC: hdmi: Remove obsolete dummy HDMI codecsound/soc/codecs/Kconfig sound/soc/codecs/Makefile sound/soc/codecs/hdmi.c+0 -1152 replies
3/7ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encodersinclude/sound/hdmi-codec.h sound/soc/codecs/Kconfig sound/soc/codecs/Makefile +1 more+563 -02 replies
4/7ASoC: hdmi-codec: Add ELD based audio pcm rules DO NOT MERGEsound/soc/codecs/hdmi-codec.c+103 -10 replies
5/7drm/i2c: tda998x: Add support of a DT graph of ports DO NOT MERGEDocumentation/devicetree/bindings/drm/i2c/tda998x.txt drivers/gpu/drm/i2c/tda998x_drv.c include/sound/tda998x.h+140 -90 replies
6/7drm/i2c: tda998x: Register ASoC HDMI codec for audio functionality DO NOT MERGEdrivers/gpu/drm/i2c/Kconfig drivers/gpu/drm/i2c/tda998x_drv.c+239 -00 replies
7/7ARM: dts: am335x-boneblack: Add HDMI audio support DO NOT MERGEarch/arm/boot/dts/am335x-boneblack.dts+76 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH RFC v2 0/7] Implement generic ASoC HDMI codec

Only the first three patches are meant for serious review.

The ASoC part should be ready for review in other respects but the EDID SADs handling is waiting for Russell King's DRM ELD helper patches. There is a copy-pasted not-to-be-merged patch with the same functionality in the patch series.

The tda998x part is not complete and I do not think Jean-Francois' binding are ready as such either. At least the usage of reg property in a port node for something that is not an address or even guaranteed to be unique is not a good idea. Some documentation of how to configure AP0-AP4 pins (REG_ENA_AP?) would help in making a proper binding for the tda998x audio configuration.

These patches, my tilcdc refactoring[1], and my latest BCLK fixes for davinci-mcasp driver [2], can be found in a branch that produces working HDMI audio on Beaglebone-Black here:

https://github.com/jsarha/linux.git linux-master-bbb-hdmi-20150512

[1] http://lists.freedesktop.org/archives/dri-devel/2015-May/082537.html
[2] http://mailman.alsa-project.org/pipermail/alsa-devel/2015-April/090974.html

Jean-Francois Moine (1):
drm/i2c: tda998x: Add support of a DT graph of ports DO NOT MERGE

Jyri Sarha (6):
ASoC: core: If component doesn't have of_node use parent's node
instead
ASoC: hdmi: Remove obsolete dummy HDMI codec
ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders
ASoC: hdmi-codec: Add ELD based audio pcm rules DO NOT MERGE drm/i2c: tda998x: Register ASoC HDMI codec for audio functionality DO
NOT MERGE
ARM: dts: am335x-boneblack: Add HDMI audio support DO NOT MERGE

 .../devicetree/bindings/drm/i2c/tda998x.txt        |  51 ++
 arch/arm/boot/dts/am335x-boneblack.dts             |  78 ++-
 drivers/gpu/drm/i2c/Kconfig                        |   1 +
 drivers/gpu/drm/i2c/tda998x_drv.c                  | 328 +++++++++++-
 include/sound/hdmi-codec.h                         |  99 ++++
 include/sound/tda998x.h                            |   8 +
 sound/soc/codecs/Kconfig                           |   2 +-
 sound/soc/codecs/Makefile                          |   4 +-
 sound/soc/codecs/hdmi-codec.c                      | 560 +++++++++++++++++++++
 sound/soc/codecs/hdmi.c                            | 109 ----
 sound/soc/soc-core.c                               |  14 +-
 11 files changed, 1129 insertions(+), 125 deletions(-)
 create mode 100644 include/sound/hdmi-codec.h
 create mode 100644 include/sound/tda998x.h
 create mode 100644 sound/soc/codecs/hdmi-codec.c
 delete mode 100644 sound/soc/codecs/hdmi.c
Signature · 1 line
1.9.1