Skip to content

Clean unused entries in the qcow2 L2/refcount cache

Alberto Garcia qemu-devel 7 versions – Applied

Status from this message: Thanks, applied to my block tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest4 patches 1 replyApplied
  2. v64 patches 4 repliesSuperseded
  3. v54 patches 7 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v43 patches6 repliesSuperseded
v33 patches16 repliesSuperseded
v23 patches4 repliesSuperseded
v13 patches9 repliesSuperseded

Changes in v7 from the cover letter

- Rebase against the current master.
- Update version number in the 'since' field of the 'cache-clean-interval' option.

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/4qcow2: mark the memory as no longer needed after qcow2_cache_empty()block/qcow2-cache.c+26 -00 replies
2/4qcow2: add option to clean unused cache entries after some timeblock/qcow2-cache.c block/qcow2.c block/qcow2.h +1 more+109 -10 replies
3/4docs: document how to configure the qcow2 L2/refcount cachesdocs/qcow2-cache.txt+164 -00 replies
4/4qcow2: reorder fields in Qcow2CachedTable to reduce paddingblock/qcow2-cache.c+1 -10 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMax ReitzEric BlakeKevin Wolf
1/4R-b
2/4R-b
3/4R-b
4/4R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [Qemu-devel] [PATCH v7 0/4] Clean unused entries in the qcow2 L2/refcount cache

v7:
- Rebase against the current master.
- Update version number in the 'since' field of the 'cache-clean-interval' option.

v6: https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01929.html
- Update documentation to clarify what "unused entries" mean.

v5: https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg00573.html
- Fix build in mingw.
- Use getpagesize() instead of sysconf(_SC_PAGESIZE).
- Clarify that 0 is the default value for 'cache-clean-interval', and that it disables the feature.
- Add the patch that documents how to configure the cache to this series, expanded with the explanation of 'cache-clean-interval'. (previous version:
https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg02253.html)

v4: https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg06120.html
- Revert the 'cache-clean-interval' change. This should probably go into a new BlockDeviceInfoSpecific struct (along with other settings), but is out of the scope for this series.

v3: https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg05473.html
- Add 'cache-clean-interval' field to ImageInfoSpecificQCow2.

v2: https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg05316.html
- Clarify that the block-commit mentioned in the first patch refers to the HMP commit command.
- Check the value of cache_clean_interval and cast it accordingly to prevent it from overflowing.

v1: https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg03510.html

Alberto Garcia (4):
qcow2: mark the memory as no longer needed after qcow2_cache_empty()
qcow2: add option to clean unused cache entries after some time
docs: document how to configure the qcow2 L2/refcount caches
qcow2: reorder fields in Qcow2CachedTable to reduce padding

 block/qcow2-cache.c  |  63 +++++++++++++++++++-
 block/qcow2.c        |  64 ++++++++++++++++++++
 block/qcow2.h        |   4 ++
 docs/qcow2-cache.txt | 164 +++++++++++++++++++++++++++++++++++++++++++++++++++
 qapi/block-core.json |   7 ++-
 5 files changed, 300 insertions(+), 2 deletions(-)
 create mode 100644 docs/qcow2-cache.txt
Signature · 1 line
2.4.6