Skip to content

clockevents: Hide CLOCK_EVT_STATE_* from rest of the kernel

Viresh Kumar lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2clockevents: Move 'enum clock_event_state' to tick-internal.hinclude/linux/clockchips.h kernel/time/tick-internal.h+22 -220 replies
2/2clockevents: Add helpers to verify state of a clockevent deviceinclude/linux/clockchips.h kernel/time/clockevents.c+42 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] clockevents: Hide CLOCK_EVT_STATE_* from rest of the kernel

Hi Thomas,

Ingo suggested [1] to keep CLOCK_EVT_STATE_* symbols somewhere in kernel/time/. We couldn't do it as bL_switcher code was using it earlier. But that's fixed now. And so the first patch moves these symbols to tick-internal.h.

Some of the drivers [2] need to verify state of the clockevent device from their callbacks or interrupt handlers.

Because these symbols (defined by 'enum clock_event_state') will now be internal to the core, we need some helpers to verify state of a clockevent device.

One way out was to maintain the state in drivers as well, but that would be unnecessary burden on them. And so the second patch introduces helpers for these states.

Rebased-over: tip/timers/core (dependency on 8fff52fd5093 ("clockevents:
Introduce CLOCK_EVT_STATE_ONESHOT_STOPPED state"))

--
viresh

[1] https://lists.linaro.org/pipermail/linaro-kernel/2015-February/020292.html
[2] http://pastebin.com/374X18mv

Viresh Kumar (2):
clockevents: Move 'enum clock_event_state' to tick-internal.h
clockevents: Add helpers to verify state of a clockevent device

 include/linux/clockchips.h  | 34 ++++++++++++----------------------
 kernel/time/clockevents.c   | 31 +++++++++++++++++++++++++++++++
 kernel/time/tick-internal.h | 21 +++++++++++++++++++++
 3 files changed, 64 insertions(+), 22 deletions(-)
Signature · 1 line
2.4.0