Skip to content

Make "set -x" in postinst scripts not break rootfs

Peter Seebach openembedded-core 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1rootfs.py: Make set -x not break rootfs creationmeta/lib/oe/rootfs.py+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] Make "set -x" in postinst scripts not break rootfs

I was trying to debug a postinstall script, so I added set -x, so rootfs creation broke. The issue is that set -x caused lines of code to be emitted in a place where the log file checker saw them. It's totally okay for a postinstall script to exit 1; that moves it into etc/rpm-postinsts, and then it runs on the target.

So it shouldn't prevent rootfs creation from "succeeding". Solution: Don't process lines preceeded by a "+", because that's probably set -x output.

The following changes since commit fe7780a9bbbfa4dcbbe457618a0842e91a3c6a0e:

libxdmcp: make libbsd usage deterministic (2015-05-21 10:48:41 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib seebs/setminusx
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/setminusx

Peter Seebach (1):
rootfs.py: Make set -x not break rootfs creation

 meta/lib/oe/rootfs.py | 3 +++
 1 file changed, 3 insertions(+)
Signature · 1 line
2.3.1