Skip to content

Audio backend cleanup

Kővágó, Zoltán qemu-devel 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 0 repliesNew
  2. v212 patches 7 repliesSuperseded
  3. v112 patches 13 repliesSuperseded

Changes in v3 from the cover letter

* fixed typo in coreaudio

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12audio: remove esd backendaudio/Makefile.objs audio/audio_int.h audio/esdaudio.c +1 more+6 -5710 replies
2/12audio: remove fmod backendaudio/Makefile.objs audio/audio_int.h audio/fmodaudio.c +1 more+2 -7130 replies
3/12audio: remove winwave audio driveraudio/Makefile.objs audio/audio_int.h audio/winwaveaudio.c +1 more+4 -7280 replies
4/12audio: expose drv_opaque to init_out and init_inaudio/alsaaudio.c audio/audio_int.h audio/audio_template.h +8 more+27 -200 replies
5/12alsaaudio: do not use global variablesaudio/alsaaudio.c+87 -730 replies
6/12paaudio: do not use global variablesaudio/paaudio.c+52 -460 replies
7/12ossaudio: do not use global variablesaudio/ossaudio.c+61 -490 replies
8/12wavaudio: do not use global variablesaudio/wavaudio.c+21 -160 replies
9/12dsoundaudio: do not use global variablesaudio/dsound_template.h audio/dsoundaudio.c+74 -500 replies
10/12paaudio: fix possible resource leakaudio/paaudio.c+5 -10 replies
11/12coreaudio: do not use global variables where possibleaudio/coreaudio.c+24 -190 replies
12/12sdlaudio: do not allow multiple instancesaudio/sdlaudio.c+7 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 00/12] Audio backend cleanup

This series of patch removes the following audio backends:
esd, fmod, winwave.

It also cleans up the remaining drivers to do not use global variables where possible. This is a preparation for my GSoC project where I will enable multiple simultaneous audio backends.

Please also test the coreaudio backend, as I do not have a Mac to test it.

Patches are also available at https://github.com/DirtYiCE/qemu.git in tag audio-cleanup-v3 to simplify testing.

Changes since v1:
* sdl no longer removed
* fixed style issues in `audio: expose drv_opaque to init_out and init_in'

Changes since v2:
* fixed typo in coreaudio

Please review.

Kővágó, Zoltán (12):
audio: remove esd backend
audio: remove fmod backend
audio: remove winwave audio driver
audio: expose drv_opaque to init_out and init_in
alsaaudio: do not use global variables
paaudio: do not use global variables
ossaudio: do not use global variables
wavaudio: do not use global variables
dsoundaudio: do not use global variables
paaudio: fix possible resource leak
coreaudio: do not use global variables where possible
sdlaudio: do not allow multiple instances

 audio/Makefile.objs     |   4 -
 audio/alsaaudio.c       | 165 ++++++-----
 audio/audio_int.h       |   7 +-
 audio/audio_template.h  |   2 +-
 audio/coreaudio.c       |  46 ++--
 audio/dsound_template.h |  24 +-
 audio/dsoundaudio.c     | 106 ++++---
 audio/esdaudio.c        | 557 -------------------------------------
 audio/fmodaudio.c       | 685 ---------------------------------------------
 audio/noaudio.c         |   4 +-
 audio/ossaudio.c        | 115 ++++----
 audio/paaudio.c         | 105 +++----
 audio/sdlaudio.c        |  10 +-
 audio/spiceaudio.c      |   5 +-
 audio/wavaudio.c        |  42 +--
 audio/winwaveaudio.c    | 717 ------------------------------------------------
 configure               |  56 +---
 17 files changed, 367 insertions(+), 2283 deletions(-)
 delete mode 100644 audio/esdaudio.c
 delete mode 100644 audio/fmodaudio.c
 delete mode 100644 audio/winwaveaudio.c
Signature · 1 line
2.4.2