Skip to content

kdbus: macros fixes

Sergei Zviagintsev lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest10 patches 13 repliesIn review

Changes in v2 from the cover letter

- fixed similar type cast issue in KDBUS_ITEMS_END macro
- all arguments in iteration macros are enclosed in parentheses, instead of using loop cursor without them
- summary phrases and commit messages updated
- documentation updates are excluded to their own patches
- added fixes for samples/kdbus
- added fixes for selftests/kdbus

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10kdbus: fix operator precedence issues in item macrosipc/kdbus/item.h+3 -31 reply
2/10kdbus: use parentheses uniformly in KDBUS_ITEMS_FOREACH macroipc/kdbus/item.h+2 -21 reply
3/10Documentation/kdbus: fix operator precedence issue in KDBUS_ITEM_NEXT macroDocumentation/kdbus/kdbus.item.xml+1 -11 reply
4/10Documentation/kdbus: use parentheses uniformly in KDBUS_ITEM_FOREACH macroDocumentation/kdbus/kdbus.item.xml+2 -21 reply
5/10selftests/kdbus: fix trivial style issuestools/testing/selftests/kdbus/kdbus-enum.h tools/testing/selftests/kdbus/kdbus-util.c tools/testing/selftests/kdbus/kdbus-util.h+11 -131 reply
6/10selftests/kdbus: fix precedence issues in macrostools/testing/selftests/kdbus/kdbus-util.h+3 -31 reply
7/10selftests/kdbus: use parentheses in iteration macros uniformlytools/testing/selftests/kdbus/kdbus-util.h+4 -41 reply
8/10samples/kdbus: add whitespacesamples/kdbus/kdbus-api.h+1 -11 reply
9/10samples/kdbus: fix operator precedence issue in KDBUS_ITEM_NEXT macrosamples/kdbus/kdbus-api.h+1 -11 reply
10/10samples/kdbus: use parentheses uniformly in KDBUS_FOREACH macrosamples/kdbus/kdbus-api.h+2 -21 reply

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchDavid Herrmann
1/10R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/10] kdbus: macros fixes

Fix type conversion and style issues in item macros.

First submission was in 2 separate emails:
https://lkml.kernel.org/g/[email protected]
https://lkml.kernel.org/g/[email protected]

Changes in v2:

- fixed similar type cast issue in KDBUS_ITEMS_END macro
- all arguments in iteration macros are enclosed in parentheses, instead of using loop cursor without them
- summary phrases and commit messages updated
- documentation updates are excluded to their own patches
- added fixes for samples/kdbus
- added fixes for selftests/kdbus

Sergei Zviagintsev (10):
kdbus: fix operator precedence issues in item macros
kdbus: use parentheses uniformly in KDBUS_ITEMS_FOREACH macro Documentation/kdbus: fix operator precedence issue in KDBUS_ITEM_NEXT
macro
Documentation/kdbus: use parentheses uniformly in KDBUS_ITEM_FOREACH
macro
selftests/kdbus: fix trivial style issues
selftests/kdbus: fix precedence issues in macros selftests/kdbus: use parentheses in iteration macros uniformly samples/kdbus: add whitespace
samples/kdbus: fix operator precedence issue in KDBUS_ITEM_NEXT macro samples/kdbus: use parentheses uniformly in KDBUS_FOREACH macro

 Documentation/kdbus/kdbus.item.xml         |  6 +++---
 ipc/kdbus/item.h                           | 10 ++++-----
 samples/kdbus/kdbus-api.h                  |  6 +++---
 tools/testing/selftests/kdbus/kdbus-enum.h |  1 +
 tools/testing/selftests/kdbus/kdbus-util.c |  2 +-
 tools/testing/selftests/kdbus/kdbus-util.h | 33 ++++++++++++++----------------
 6 files changed, 28 insertions(+), 30 deletions(-)
Signature · 1 line
1.8.3.1