Skip to content

support watch/notify version 2

Douglas Fuller ceph-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 4 repliesIn review
  2. v16 patches 11 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ceph/rbd: add support for watch notify payloadsdrivers/block/rbd.c include/linux/ceph/osd_client.h net/ceph/osd_client.c+23 -80 replies
2/6ceph/rbd: add support for header version 2 and 3drivers/block/rbd.c include/linux/ceph/osd_client.h net/ceph/osd_client.c+28 -120 replies
3/6ceph/rbd: update watch-notify ceph_osd_opdrivers/block/rbd.c include/linux/ceph/ceph_fs.h include/linux/ceph/osd_client.h +2 more+107 -250 replies
4/6osd_client, rbd: update event interface for watch/notify2drivers/block/rbd.c include/linux/ceph/osd_client.h net/ceph/osd_client.c+175 -641 reply
5/6osd_client: add support for notify payloads via notify eventinclude/linux/ceph/osd_client.h net/ceph/osd_client.c+131 -73 replies
6/6osd_client: send watch ping messagesinclude/linux/ceph/osd_client.h net/ceph/osd_client.c+19 -10 replies

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchJosh Durgin
1/6R-b
2/6R-b
3/6R-b
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCHv2 0/6] support watch/notify version 2

osd_client, rbd: add support for version 2 of watch/notify

Support watch/notify 2 in osd_client and update rbd for compatibility. Map ceph_osd_event to expected watch/notify messages and store watch and watch error callbacks. Implement CEPH_OSD_WATCH_OP_PING and CEPH_OSD_WATCH_OP_RECONNECT. Handle CEPH_WATCH_EVENT_DISCONNECT. Handle CEPH_WATCH_EVENT_NOTIFY_COMPLETE and provide a data item for clients to consume.

v2: incorporated changes from Mike, Josh, and Ilya. Changed notify-ack data to page vector and size instead of ceph_msg_data and other fixes.

Douglas Fuller (3):
osd_client, rbd: update event interface for watch/notify2
osd_client: add support for notify payloads via notify event
osd_client: send watch ping messages

Mike Christie (3):
ceph/rbd: add support for watch notify payloads ceph/rbd: add support for header version 2 and 3 ceph/rbd: update watch-notify ceph_osd_op

 drivers/block/rbd.c             |  54 ++++--
 include/linux/ceph/ceph_fs.h    |   6 +-
 include/linux/ceph/osd_client.h |  55 ++++--
 include/linux/ceph/rados.h      |  18 +-
 net/ceph/osd_client.c           | 387 +++++++++++++++++++++++++++++++++++-----
 5 files changed, 443 insertions(+), 77 deletions(-)
Signature · 1 line
1.9.3