Skip to content

RFC QOM prop overloading + ARM MPCore CPUs

Peter Crosthwaite qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest8 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8qom: Refactor array property code pathqom/object.c+9 -60 replies
2/8qom: Add property overloadinginclude/qom/object.h qom/object.c+14 -80 replies
3/8qom: Implement overloaded property settersqom/object.c+19 -100 replies
4/8qom: Delete all instances of an overloaded propertyqom/object.c+14 -120 replies
5/8qom: Disallow getting/resolving an overloaded propertyqom/object.c+4 -10 replies
6/8qom: Enable overloading of Alias propertiesqom/object.c+1 -00 replies
7/8arm: realview: Factor out CPU property settershw/arm/realview.c+27 -190 replies
8/8arm: axxmpcore: Add CPUs to MPCorehw/arm/exynos4210.c hw/arm/highbank.c hw/arm/realview.c +8 more+253 -3520 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [RFC PATCH v1 0/8] QOM prop overloading + ARM MPCore CPUs

Hi All,

This series introduced support for multi QOM properties with the same name and then moves the ARM CPUs to the MPCore container objects (yes! they are related!)

The application of the QOM change is container objects passing through a single property on multiple same-type children as a single alias. The immediate use case, is the ARM MPCore where we want to add N cpus but pass through the CPU properties for all of them as an alias on the container itself. The container property setter should fan out to all the CPUs in the container.

Patches 1-5 implement overloaded properties as part of QOM. QOM properties do not allow overloading by default, the creator of the property has to switch it on.

Patch 6 switches this feature on for alias properties which handles the container use case.

Patch 8 is the feature presentation, pulling the CPUs into the ARM MPCore container. This is based on a series of Alistair's to do the same. This version does the extra refactoring to handle the case of multiple CPUs and the problems created around aliases.

Extra discussion points:

The QOM work will probably conflict with Pavel Fedin' work of arrayified properties. So I'll resolve that conflict in a future spin.

Liviu recently brought up a desire for arguments to QOM constructors. P8 would probably be cleaner if this feature existed, as the number of CPUs could be set as a constructor argument. There is no flexibility on when this has to be set, it must be done immediately after construction so it ideally should be part of construction.

My biggest fear is testing of the changes for the affected boards. Peter, do you much coverage of these boards in your regressions? Do you have automated tests in a git repo somewhere?

Regards,
Peter

Peter Crosthwaite (8):
qom: Refactor array property code path
qom: Add property overloading
qom: Implement overloaded property setters
qom: Delete all instances of an overloaded property
qom: Disallow getting/resolving an overloaded property
qom: Enable overloading of Alias properties
arm: realview: Factor out CPU property setters
arm: axxmpcore: Add CPUs to MPCore

 hw/arm/exynos4210.c         |  72 +++++++-----------------------
 hw/arm/highbank.c           |  65 +++++----------------------
 hw/arm/realview.c           | 100 +++++++++++++++++++++++------------------
 hw/arm/vexpress.c           |  71 +++++++-----------------------
 hw/arm/xilinx_zynq.c        |  65 ++++++++++-----------------
 hw/cpu/a15mpcore.c          |  66 ++++++++++++++++++++++++----
 hw/cpu/a9mpcore.c           |  97 +++++++++++++++++++++++++++++++++++++---
 hw/intc/exynos4210_gic.c    | 105 --------------------------------------------
 include/hw/arm/exynos4210.h |   2 -
 include/hw/cpu/a15mpcore.h  |   2 +
 include/hw/cpu/a9mpcore.h   |   6 +++
 include/qom/object.h        |   2 +
 qom/object.c                |  96 ++++++++++++++++++++++++----------------
 13 files changed, 341 insertions(+), 408 deletions(-)
Signature · 1 line
2.4.3.3.g905f831