qom-cpu: Wrap set_pc hook and use in bootloaders
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 12 repliesIn review
- v24 patches 14 repliesSuperseded
- v15 patches 3 repliesSuperseded
Changes in v3 from the cover letter
drop error argument
misc commit messages tweaks
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | cpu: Add wrapper to the set-pc() hookinclude/ | +17 | 5 replies | |
| 2/4 | gdbstub: Use cpu_set_pc() helpergdbstub.c | +1 | 0 replies | |
| 3/4 | arm: boot: Use cpu_set_pc()hw/ | +7 | 3 replies | |
| 4/4 | microblaze: boot: Use cpu_set_pc()dtc hw/ | +2 | 3 replies |
Reviews trailers per patch
2 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Peter Maydell | Andreas Färber |
|---|---|---|
| 1/4 | ||
| 2/4 | ||
| 3/4 | R-b | R-b |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH qom v3 0/4] qom-cpu: Wrap set_pc hook and use in bootloaders
Wrap the CPUClass::set_pc fn hook in a caller helper to reduce verbosity of calls. Simplify the call from the gdbstub.
Then use the call to abstract away the PC env fields from the ARM and Microblaze bootloaders.
This moves towards the goal of minimising system level code of the CPU env (and one step closer to common-obj'ing the bootloaders). There's a long way to go (at least for ARM, not so far for MB), but this is a small win in that direction.
This helps with multi-arch where the current thinking is to compile out the maximum content possible from cpu.h. This removes program counter definitions from the multi-arch cpu.h compile-in list.
changed since v2:
drop error argument
misc commit messages tweaks
changed since v1:
Remove thumb changes
Peter Crosthwaite (4):
cpu: Add wrapper to the set-pc() hook
gdbstub: Use cpu_set_pc() helper
arm: boot: Use cpu_set_pc()
microblaze: boot: Use cpu_set_pc()
dtc | 2 +- gdbstub.c | 5 +---- hw/arm/boot.c | 19 +++++++------------ hw/microblaze/boot.c | 2 +- include/qom/cpu.h | 17 +++++++++++++++++ 5 files changed, 27 insertions(+), 18 deletions(-)
Signature · 1 line
1.9.1