Skip to content

CPUFreq: governors: further cleanups

Viresh Kumar linux-pm lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 20 repliesIn review
  2. v29 patches 16 repliesSuperseded
  3. v110 patches 13 repliesSuperseded

Changes in v3 from the cover letter

- Few got merged already, and are dropped now
- Patches are reordered a bit to make them more sensible
- gov_queue_work() isn't modified at all with the mask of CPUs, as you suggested earlier.
- Some minor commit/logs updated.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5cpufreq: ondemand: Drop unnecessary locks from update_sampling_rate()drivers/cpufreq/cpufreq_ondemand.c+1 -96 replies
2/5cpufreq: ondemand: update sampling rate immediatelydrivers/cpufreq/cpufreq_ondemand.c+4 -216 replies
3/5cpufreq: ondemand: queue work for policy->cpus togetherdrivers/cpufreq/cpufreq_ondemand.c+13 -64 replies
4/5cpufreq: governor: Quit work-handlers early if governor is stoppeddrivers/cpufreq/cpufreq_governor.c+23 -104 replies
5/5cpufreq: Get rid of ->governor_enabled and its lockdrivers/cpufreq/cpufreq.c include/linux/cpufreq.h+0 -250 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchPreeti U Murthy
1/5R-b
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH V3 0/5] CPUFreq: governors: further cleanups

Hi Rafael,

Here is the third version based on the review comments you gave. I have tried to resolve most of them, and it looks much better now. Thanks for your comments.

As I am traveling this week, don't have access to hardware to retest the series. But I am quite sure it should work just fine, as there weren't lots of updates from how the final code looked earlier. Anyway, I have pushed this for the build bot sometime back and it will let us know of any obvious issues.

V2->V3:
- Few got merged already, and are dropped now
- Patches are reordered a bit to make them more sensible
- gov_queue_work() isn't modified at all with the mask of CPUs, as you suggested earlier.
- Some minor commit/logs updated.

V1->V2:
- Dropped 2/10 from V1 as it wasn't required
- 3/10 saw some changes due to above patch being dropped
- 7/10 changed a bit as we check for pending work items by looking at shared->policy, rather than calling delayed_work_pending. We wanted to check if governor is operational or not and the new check is enough for that.

Viresh Kumar (5):
cpufreq: ondemand: Drop unnecessary locks from update_sampling_rate()
cpufreq: ondemand: update sampling rate immediately
cpufreq: ondemand: queue work for policy->cpus together
cpufreq: governor: Quit work-handlers early if governor is stopped
cpufreq: Get rid of ->governor_enabled and its lock

 drivers/cpufreq/cpufreq.c          | 24 ------------------
 drivers/cpufreq/cpufreq_governor.c | 33 +++++++++++++++++--------
 drivers/cpufreq/cpufreq_ondemand.c | 50 ++++++++++++--------------------------
 include/linux/cpufreq.h            |  1 -
 4 files changed, 39 insertions(+), 69 deletions(-)
Signature · 1 line
2.4.0