Skip to content

kconfig: warn of unhandled characters in Kconfig commands

Andreas Ruprecht linux-kbuild lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 2 repliesIn review
  2. v32 patches 2 repliesSuperseded
  3. v22 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches5 repliesSuperseded

Changes to v1 from the cover letter

- add '---help---' in zconf.gperf instead of special casing it in zconf.l

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2kconfig: warn of unhandled characters in Kconfig commandsscripts/kconfig/zconf.gperf scripts/kconfig/zconf.l+12 -90 replies
2/2kconfig: Regenerate shipped zconf.{hash,lex}.c filesscripts/kconfig/zconf.hash.c_shipped scripts/kconfig/zconf.lex.c_shipped+192 -1910 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchUlf Magnusson
SeriesR-b T-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] kconfig: warn of unhandled characters in Kconfig commands

This patchset changes the lexer file to emit a warning if any unhandled characters are found in the input. So far, Kconfig options like

+config FOO

    bool
    [...]

(note the wrong '+'!) were parsed without a warning. As simply adding a warning for '.' produces lots of warnings as occasionally '---help---' is used instead of 'help' (and thus '-' is recognized as an unhandled character), we need to handle '---help---' separately.

Changes to v1:
- add '---help---' in zconf.gperf instead of special casing it in zconf.l

Changes to v2:
- Do no constify char parameter to warn_ignored_character
- Shorten rule definitions for '.'

Changes to v3:
- spaces -> tabs in zconf.gperf

Andreas Ruprecht (2):
kconfig: warn of unhandled characters in Kconfig commands
kconfig: Regenerate shipped zconf.{hash,lex}.c files

 scripts/kconfig/zconf.gperf          |   1 +
 scripts/kconfig/zconf.hash.c_shipped |  58 ++++---
 scripts/kconfig/zconf.l              |  20 ++-
 scripts/kconfig/zconf.lex.c_shipped  | 325 +++++++++++++++++------------------
 4 files changed, 204 insertions(+), 200 deletions(-)
Signature · 1 line
1.9.1

Read the cover letter in its thread