Skip to content

Remove invalid sed command

Robert Yang openembedded-core 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12elfutils 0.163: remove do_configure_prependmeta/recipes-devtools/elfutils/elfutils-0.148/i386_dis.h meta/recipes-devtools/elfutils/elfutils-0.148/x86_64_dis.h meta/recipes-devtools/elfutils/elfutils_0.163.bb+0 -100 replies
2/12opkg: remove do_configure_prependmeta/recipes-devtools/opkg/opkg_0.2.4.bb+0 -50 replies
3/12glibc-initial: remove invalid sed commandmeta/recipes-core/glibc/glibc-initial.inc+0 -20 replies
4/12qemu: remove invalid sed commandmeta/recipes-devtools/qemu/qemu.inc+0 -100 replies
5/12rpm: remove invalid sed commandmeta/recipes-devtools/rpm/rpm_5.4+cvs.bb meta/recipes-devtools/rpm/rpm_5.4.14.bb+0 -20 replies
6/12mdadm: remove do_configure_prependmeta/recipes-extended/mdadm/mdadm_3.3.2.bb+0 -50 replies
7/12perl: remove invalid sed commandmeta/recipes-devtools/perl/perl_5.22.0.bb+0 -30 replies
8/12python: remove invalid sed commandmeta/recipes-devtools/python/python3_3.4.3.bb meta/recipes-devtools/python/python_2.7.9.bb+0 -50 replies
9/12python-pygtk: remove invalid sed commandmeta/recipes-devtools/python/python-pygtk_2.24.0.bb+0 -210 replies
10/12perf: remove invalid sed commandmeta/recipes-kernel/perf/perf.bb+0 -60 replies
11/12cups: remove invalid sed commandmeta/recipes-extended/cups/cups.inc+0 -30 replies
12/12qt4: fixes for sed commandmeta/recipes-qt/qt4/qt4-4.8.7.inc meta/recipes-qt/qt4/qt4.inc+2 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/12] Remove invalid sed command

The sed doesn't return false when miss match, I use a rough wrapper to find out the mis matches:

1) s/sed -i/mysed -i/ in the recipes

  $ find meta -name '*.bbclass' -o -name '*.bb' -o -name '*.inc' -exec sed -i 's/[[:space:]]sed -i/ mysed -i/g' {} \;
2)  Add mysed to tmp/sysroots/x86_64-linux/usr/bin:
#!/bin/sh

for i in "$@"; do

    if [ -e "$i" ]; then
        cp "$i" "$i".sedbak
        /bin/sed "$@"
        num=`diff "$i" "$i".sedbak | wc -l`
        if [ $num -eq 0 ]; then
            echo "`pwd` XXX $@" >>/tmp/nothing_did_sed
        fi  
        rm -f "$i".sedbak
    fi  

done

3) Check /tmp/nothing_did_sed one by one and fix them.

// Robert

The following changes since commit 5a1f80e15d7fb60fd7c2b82aa769adef95d877a9:

libtool: Fix regression from previous commit (2015-07-09 17:58:50 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib rbt/sed
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=rbt/sed

Robert Yang (12):
elfutils 0.163: remove do_configure_prepend
opkg: remove do_configure_prepend
glibc-initial: remove invalid sed command
qemu: remove invalid sed command
rpm: remove invalid sed command
mdadm: remove do_configure_prepend
perl: remove invalid sed command
python: remove invalid sed command
python-pygtk: remove invalid sed command
perf: remove invalid sed command
cups: remove invalid sed command
qt4: fixes for sed command

 meta/recipes-core/glibc/glibc-initial.inc          |    2 --
 .../{elfutils => elfutils-0.148}/i386_dis.h        |    0
 .../{elfutils => elfutils-0.148}/x86_64_dis.h      |    0
 meta/recipes-devtools/elfutils/elfutils_0.163.bb   |   10 ----------
 meta/recipes-devtools/opkg/opkg_0.2.4.bb           |    5 -----
 meta/recipes-devtools/perl/perl_5.22.0.bb          |    3 ---
 .../recipes-devtools/python/python-pygtk_2.24.0.bb |   21 --------------------
 meta/recipes-devtools/python/python3_3.4.3.bb      |    2 --
 meta/recipes-devtools/python/python_2.7.9.bb       |    3 ---
 meta/recipes-devtools/qemu/qemu.inc                |   10 ----------
 meta/recipes-devtools/rpm/rpm_5.4+cvs.bb           |    1 -
 meta/recipes-devtools/rpm/rpm_5.4.14.bb            |    1 -
 meta/recipes-extended/cups/cups.inc                |    3 ---
 meta/recipes-extended/mdadm/mdadm_3.3.2.bb         |    5 -----
 meta/recipes-kernel/perf/perf.bb                   |    6 ------
 meta/recipes-qt/qt4/qt4-4.8.7.inc                  |    8 ++------
 meta/recipes-qt/qt4/qt4.inc                        |    3 ---
 17 files changed, 2 insertions(+), 81 deletions(-)
 rename meta/recipes-devtools/elfutils/{elfutils => elfutils-0.148}/i386_dis.h (100%)
 rename meta/recipes-devtools/elfutils/{elfutils => elfutils-0.148}/x86_64_dis.h (100%)
Signature · 1 line
1.7.9.5