Fixes for shell message changes (OE-Core side)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | classes/useradd: don't read bbnote/bbwarn/bbfatal valuesmeta/ | +3 | 0 replies | |
| 2/4 | classes/base: fix die() to print the full logmeta/ meta/ | +9 | 0 replies | |
| 3/4 | Use die() or bbfatal_log() where the log should definitely be printedmeta/ meta/ meta/ +1 more | +13 | 0 replies | |
| 4/4 | classes/logging: allow shell message functions to work in devshellmeta/ | +35 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] Fixes for shell message changes (OE-Core side)
Unfortunately the shell message changes caused a few minor regressions; this is a perfect example of a situation where what seems like a simple and logical change can have unintended consequences that you'll miss if you're not careful. More testing all round would probably be advisable in future. Having said that, it has had the effect of highlighting something that we need to be mindful of in future - don't call bbfatal() where you expect the rest of the error log to be printed - use die() or bbfatal_log() for that, or alternatively make your message meaningful enough that you don't need the log.
NOTE: the fix for die() and bbfatal_log() requires the BitBake change that implements bbfatal_log internally which has just sent to the bitbake-devel list. Having said that, logging.bbclass now works as it used to for older BitBake versions that didn't have the message support at all.
The following changes since commit 6be698b7270f73f40d38713ecf13f12aec0ced61:
dpkg: Fix for Fedora22 and new versions of tar (2015-07-13 13:46:45 +0100)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib paule/oecore-shell-logging-fixes
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/oecore-shell-logging-fixes
Paul Eggleton (4):
classes/useradd: don't read bbnote/bbwarn/bbfatal values classes/base: fix die() to print the full log
Use die() or bbfatal_log() where the log should definitely be printed classes/logging: allow shell message functions to work in devshell
meta/classes/autotools.bbclass | 4 +-- meta/classes/base.bbclass | 2 +- meta/classes/kernel-yocto.bbclass | 16 +++++----- meta/classes/logging.bbclass | 48 +++++++++++++++++++++++++---- meta/classes/scons.bbclass | 4 +-- meta/classes/useradd.bbclass | 6 ++-- meta/recipes-extended/groff/groff_1.22.3.bb | 2 +- 7 files changed, 59 insertions(+), 23 deletions(-)
Signature · 1 line
2.1.0