Skip to content

bmc150_magn fix and cleanup

Hartmut Knaack linux-iio 1 version Applied

Status from this message: Applied to the fixes-togreg branch of iio.git

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 18 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/8iio:magnetometer:bmc150_magn: add regmap dependencydrivers/iio/magnetometer/Kconfig+1 -01 reply
2/8iio:magnetometer:bmc150_magn: sort entry alphabeticallydrivers/iio/magnetometer/Kconfig drivers/iio/magnetometer/Makefile+19 -172 replies
3/8iio:magnetometer:bmc150_magn: output intended variabledrivers/iio/magnetometer/bmc150_magn.c+2 -21 reply
4/8iio:magnetometer:bmc150_magn: replace magic valuedrivers/iio/magnetometer/bmc150_magn.c+3 -11 reply
5/8iio:magnetometer:bmc150_magn: add error handling on gpio probedrivers/iio/magnetometer/bmc150_magn.c+6 -13 replies
6/8iio:magnetometer:bmc150_magn: protect runtime_resume with mutexdrivers/iio/magnetometer/bmc150_magn.c+7 -23 replies
7/8iio:magnetometer:bmc150_magn: expand mutex in trigger_handlerdrivers/iio/magnetometer/bmc150_magn.c+1 -12 replies
8/8iio:magnetometer:bmc150_magn: use descriptive name for maskdrivers/iio/magnetometer/bmc150_magn.c+3 -22 replies

Reviews trailers per patch

2 of 8 patches have a Reviewed-by or Acked-by.

PatchIrina Tirdea
1/8
2/8
3/8
4/8
5/8
6/8
7/8A-b
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] bmc150_magn fix and cleanup

Some issues I spotted during review of this driver. First three are quite obvious problems, the rest may be matter of taste or intended to stay in the original form. Opinions welcome.

Hartmut Knaack (8):
iio:magnetometer:bmc150_magn: add regmap dependency iio:magnetometer:bmc150_magn: sort entry alphabetically iio:magnetometer:bmc150_magn: output intended variable iio:magnetometer:bmc150_magn: replace magic value iio:magnetometer:bmc150_magn: add error handling on gpio probe iio:magnetometer:bmc150_magn: protect runtime_resume with mutex iio:magnetometer:bmc150_magn: expand mutex in trigger_handler iio:magnetometer:bmc150_magn: use descriptive name for mask

 drivers/iio/magnetometer/Kconfig       | 32 ++++++++++++++++++--------------
 drivers/iio/magnetometer/Makefile      |  3 +--
 drivers/iio/magnetometer/bmc150_magn.c | 31 ++++++++++++++++++++++---------
 3 files changed, 41 insertions(+), 25 deletions(-)
Signature · 1 line
2.4.3