Skip to content

xlnx-zynqmp: Connect the AHCI SATA device

Alistair Francis qemu-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 of 4 patches 14 repliesIn review
  2. v53 of 4 patches 0 repliesSuperseded
  3. v43 of 4 patches 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 of 4 patches7 repliesSuperseded
v23 of 4 patches2 repliesSuperseded
v13 patches23 repliesSuperseded

Changes in v6 from the cover letter

- Fix up Macros

3 of 4 patches are in this archive. The cover letter announces 4.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ahci: Separate the AHCI state structure into the headerhw/ide/ahci.c hw/ide/ahci.h+14 -130 replies
2/4ahci.c: Don't assume AHCIState's parent is AHCIPCIStatehw/ide/ahci.c hw/ide/ahci.h+9 -63 replies
3/4xlnx-zynqmp.c: Convert some of the error_propagate() calls to error_aborthw/arm/xlnx-zynqmp.c+2 -120 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSai Pavan BodduPeter CrosthwaiteJohn Snow
SeriesR-b
1/4R-b R-b
2/4R-b A-b
3/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [Qemu-devel] [PATCH v6 0/4] xlnx-zynqmp: Connect the AHCI SATA device

This series connects the AHCI SATA device to the ZynqMP machine. It requires a restructure of the AHCI file to make the AHCI state struct visible. It also requires a small change to the ahci_irq_lower() and ahci_irq_raise() functions to avoid assuming that the AHCIState is a child of AHCIPCIState.

V6:
- Fix up Macros
V5:
- Remove the return checks when setting PCIDevice
V4:
- Remove unnesicary casts
- Use object_dynamic_cast() instead of object_class_dynamic_cast()
V3:
- Perform checks inside the ahci_irq_lower() and ahci_irq_raise() functions to ensure the correct parent object is used.
V2:
- Macroify the number of SATA ports
- Update the non-realise error_propagate() calls to
use error_abort instead.

Alistair Francis (4):
ahci: Seperate the AHCI state structure into the header ahci.c: Don't assume AHCIState's parent is AHCIPCIState xlnx-zynqmp.c: Convert some of the error_propagate() calls to
error_abort
xlnx-zynqmp: Connect the sysbus AHCI to ZynqMP

 hw/arm/xlnx-zynqmp.c         |   32 ++++++++++++++++++++------------
 hw/ide/ahci.c                |   26 +++++++-------------------
 hw/ide/ahci.h                |   16 ++++++++++++++++
 include/hw/arm/xlnx-zynqmp.h |    3 +++
 4 files changed, 46 insertions(+), 31 deletions(-)