Skip to content

hw/arm/gic: Code duplication removal

Pavel Fedin qemu-devel 2 versions – Applied

Status from this message: Thanks, applied to target-arm-post-2.4.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyApplied
  2. v13 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- Use correct size of CPU interface region for pre-v2 GICs
- Improved comments

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3Merge memory_region_init_reservation() into memory_region_init_io()include/exec/memory.h memory.c+12 -120 replies
2/3hw/arm/gic: Kill code duplicationhw/intc/arm_gic.c hw/intc/arm_gic_common.c hw/intc/arm_gic_kvm.c +1 more+64 -720 replies
3/3Introduce gic_class_name() instead of repeating conditionhw/arm/virt.c hw/cpu/a15mpcore.c target-arm/kvm_arm.h+10 -100 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchPeter MaydellPaolo Bonzini
1/3R-b A-b
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/3] hw/arm/gic: Code duplication removal

I decided to make this small patchset in order to try to push some of my changes before 2.4 is out. Idea of first patch of this set came during vGICv3 implementation. In order to be able to upstream it earlier i decided to make it doing something useful and refactored GICv2 code.

This patchset contains no functional enhancements. Only cleanup and refactor.

v1 -> v2:
- Use correct size of CPU interface region for pre-v2 GICs
- Improved comments

Pavel Fedin (3):
Merge memory_region_init_reservation() into memory_region_init_io() hw/arm/gic: Kill code duplication
Introduce gic_class_name() instead of repeating condition

 hw/arm/virt.c                    |  7 ++---
 hw/cpu/a15mpcore.c               |  8 ++---
 hw/intc/arm_gic.c                | 64 ++++++++++++----------------------------
 hw/intc/arm_gic_common.c         | 41 +++++++++++++++++++++++++
 hw/intc/arm_gic_kvm.c            | 28 +-----------------
 include/exec/memory.h            | 14 +++++++--
 include/hw/intc/arm_gic_common.h |  3 ++
 memory.c                         | 10 +------
 target-arm/kvm_arm.h             |  5 ++++
 9 files changed, 86 insertions(+), 94 deletions(-)
Signature · 1 line
1.9.5.msysgit.0