Skip to content

ed/toaster/fix-toastergui/tests

Ed Bartosh yocto-toaster 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9toaster: fix test_get_json_call_returns_json testbitbake/lib/toaster/toastergui/tests.py+6 -60 replies
2/9toaster: fix test_xhr_datatypeahead_layer testbitbake/lib/toaster/toastergui/tests.py+3 -50 replies
3/9toaster: wrap long linesbitbake/lib/toaster/toastergui/tests.py+29 -140 replies
4/9toaster: get rid of AllProjectsViewTestCasebitbake/lib/toaster/toastergui/tests.py+1 -40 replies
5/9toaster: put all test cases into one classbitbake/lib/toaster/toastergui/tests.py+15 -250 replies
6/9toaster: get rid of class attribute LAYER_NAMEbitbake/lib/toaster/toastergui/tests.py+1 -20 replies
7/9toaster: remove unused importbitbake/lib/toaster/toastergui/tests.py+1 -10 replies
8/9toaster: add header and docstingbitbake/lib/toaster/toastergui/tests.py+28 -00 replies
9/9toaster: don't catch json.load exceptionsbitbake/lib/toaster/toastergui/tests.py+4 -101 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [review request] [PATCH 0/9] ed/toaster/fix-toastergui/tests

This patchset contains fixes and code cleanups for toastergui tests. Some tests were completely rewritten.

Now all 3 test cases are passed and pylint score is 10.

The following changes since commit a8b723498c9a7106210db140452886894494b4d6:

bitbake: cooker: Resolve file monitoring race issues when using memres bitbake (2015-08-03 07:36:25 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/toaster/fix-toastergui-tests
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/fix-toastergui-tests

Ed Bartosh (9):
toaster: fix test_get_json_call_returns_json test
toaster: fix test_xhr_datatypeahead_layer test
toaster: wrap long lines
toaster: get rid of AllProjectsViewTestCase
toaster: put all test cases into one class
toaster: get rid of class attribute LAYER_NAME
toaster: remove unused import
toaster: add header and docsting
toaster: don't catch json.load exceptions

 bitbake/lib/toaster/toastergui/tests.py | 119 +++++++++++++++++++-------------
 1 file changed, 70 insertions(+), 49 deletions(-)

--
Regards,
Ed