Skip to content

staging: rtl8192u: r8192U_core: fix all checkpatch.pl reports

Raphaël Beamonte lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest19 patches 4 repliesIn review
  2. v120 patches 9 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19staging: rtl8192u: r8192U_core: fix switch and case indent code style errordrivers/staging/rtl8192u/r8192U_core.c+95 -950 replies
2/19staging: rtl8192u: r8192U_core: fix space before close parenthesis code style errordrivers/staging/rtl8192u/r8192U_core.c+1 -10 replies
3/19staging: rtl8192u: r8192U_core: fix code indent using spaces code style errordrivers/staging/rtl8192u/r8192U_core.c+1 -10 replies
4/19staging: rtl8192u: r8192U_core: fix else following close brace code style errordrivers/staging/rtl8192u/r8192U_core.c+1 -20 replies
5/19staging: rtl8192u: r8192U_core: fix missing struct leading to consistent spacing code style errordrivers/staging/rtl8192u/r8192U.h drivers/staging/rtl8192u/r8192U_core.c+5 -50 replies
6/19staging: rtl8192u: r8192U_core: whitespace neatening to fix consistent spacing code style errorsdrivers/staging/rtl8192u/r8192U_core.c+144 -1440 replies
7/19staging: rtl8192u: r8192U_core: clean C99 // commentsdrivers/staging/rtl8192u/r8192U_core.c+316 -3200 replies
8/19staging: rtl8192u: r8192U_core: include linux/uaccess.h instead of asm/uaccess.hdrivers/staging/rtl8192u/r8192U_core.c+1 -10 replies
9/19staging: rtl8192u: r8192U_core: remove return statement of void functiondrivers/staging/rtl8192u/r8192U_core.c+0 -10 replies
10/19staging: rtl8192u: r8192U_core: fix unecessary braces code style issuedrivers/staging/rtl8192u/r8192U_core.c+4 -60 replies
11/19staging: rtl8192u: r8192U_core: remove forward declarations in .c filedrivers/staging/rtl8192u/r8192U_core.c+0 -60 replies
12/19staging: rtl8192u: r8192U_core: fix unnecessary check before kfree code style issuedrivers/staging/rtl8192u/r8192U_core.c+5 -80 replies
13/19staging: rtl8192u: r8192U_core: fix unnecessary parentheses code style issuedrivers/staging/rtl8192u/r8192U_core.c+2 -20 replies
14/19staging: rtl8192u: r8192U_core: fix unnecessary else after return code style issuedrivers/staging/rtl8192u/r8192U_core.c+14 -170 replies
15/19staging: rtl8192u: r8192U_core: fix unnecessary whitespace code style issuedrivers/staging/rtl8192u/r8192U_core.c+6 -60 replies
16/19staging: rtl8192u: r8192U_core: fix missing blank line after declarations code style issuedrivers/staging/rtl8192u/r8192U_core.c+41 -30 replies
17/19staging: rtl8192u: r8192U_core: fix quoted string split across lines code style issuedrivers/staging/rtl8192u/r8192U_core.c+4 -40 replies
18/19staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() code style issuedrivers/staging/rtl8192u/r8192U_core.c+1 -14 replies
19/19staging: rtl8192u: r8192U_core: fix line over 80 characters code style issuedrivers/staging/rtl8192u/r8192U_core.c+850 -3981 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCHv2 00/19] staging: rtl8192u: r8192U_core: fix all checkpatch.pl reports

Hi,

Here is an update of the patches fixing all the checkpatch warnings and errors for the file drivers/staging/rtl8192u/r8192U_core.c, thanks to Sudop Mukherjee's remarks and advices.

As a reminder, here is the checkpatch.pl tailed output before patches:

	total: 334 errors, 402 warnings, 4909 lines checked

And after patches:
total: 0 errors, 0 warnings, 5379 lines checked

Please let me know if there is anything else I can do to improve these patches!

Thanks,
Raphaël

Raphaël Beamonte (19):
staging: rtl8192u: r8192U_core: fix switch and case indent code style
error
staging: rtl8192u: r8192U_core: fix space before close parenthesis
code style error
staging: rtl8192u: r8192U_core: fix code indent using spaces code
style error
staging: rtl8192u: r8192U_core: fix else following close brace code
style error
staging: rtl8192u: r8192U_core: fix missing struct leading to
consistent spacing code style error
staging: rtl8192u: r8192U_core: whitespace neatening to fix consistent
spacing code style errors
staging: rtl8192u: r8192U_core: clean C99 // comments
staging: rtl8192u: r8192U_core: include linux/uaccess.h instead of
asm/uaccess.h
staging: rtl8192u: r8192U_core: remove return statement of void
function
staging: rtl8192u: r8192U_core: fix unecessary braces code style issue
staging: rtl8192u: r8192U_core: remove forward declarations in .c file
staging: rtl8192u: r8192U_core: fix unnecessary check before kfree
code style issue
staging: rtl8192u: r8192U_core: fix unnecessary parentheses code style
issue
staging: rtl8192u: r8192U_core: fix unnecessary else after return code
style issue
staging: rtl8192u: r8192U_core: fix unnecessary whitespace code style
issue
staging: rtl8192u: r8192U_core: fix missing blank line after
declarations code style issue
staging: rtl8192u: r8192U_core: fix quoted string split across lines
code style issue
staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over
memcpy() code style issue
staging: rtl8192u: r8192U_core: fix line over 80 characters code style
issue

 drivers/staging/rtl8192u/r8192U.h      |    4 +-
 drivers/staging/rtl8192u/r8192U_core.c | 2262 +++++++++++++++++++-------------
 2 files changed, 1368 insertions(+), 898 deletions(-)
Signature · 1 line
2.1.4