Skip to content

Allow passing BlockdevOptions to blockdev-snapshot-sync

Alberto Garcia qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1block: Allow passing BlockdevOptions to blockdev-snapshot-syncblockdev.c hmp.c qapi/block-core.json +1 more+64 -910 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/1] Allow passing BlockdevOptions to blockdev-snapshot-sync

Here's my first attempt to solve the problem explained here:

https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02847.html

In short: there's no way to pass options to snapshots created using blockdev-snapshot-sync.

This patch simply allows passing a BlockdevOptions structure to that command. I'm not 100% happy with the API because there's some overlap with a couple of parameters, but it's the simplest I could think of.

This need to be applied on top of this series from Max Reitz:

https://lists.gnu.org/archive/html/qemu-block/2015-08/msg00189.html

Regards,

Berto

Alberto Garcia (1):
block: Allow passing BlockdevOptions to blockdev-snapshot-sync

 blockdev.c           | 59 ++++++++++++++++++++++++++++++++++++++++++++++------
 hmp.c                |  2 +-
 qapi/block-core.json |  9 +++++++-
 qmp-commands.hx      |  3 ++-
 4 files changed, 64 insertions(+), 9 deletions(-)
Signature · 1 line
2.5.0