Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 10 repliesIn review
- v22 patches 10 repliesApplied
- v1 RFC2 patches 6 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | util - add automated ID generation utilityinclude/ util/ | +45 | 5 replies | |
| 2/4 | block: auto-generated node-namesblock.c | +12 | 1 reply | |
| 3/4 | block: add filter for generated node-namestests/ | +5 | 0 replies | |
| 4/4 | qemu-iotests: update tests for generated node-namestests/ tests/ tests/ +4 more | +15 | 2 replies |
Reviews trailers per patch
2 of 4 patches have a Reviewed-by or Acked-by.
| Patch | John Snow | Eric Blake | Alberto Garcia | Markus Armbruster |
|---|---|---|---|---|
| 1/4 | R-b | R-b | R-b | |
| 2/4 | R-b | R-b | R-b | |
| 3/4 | ||||
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [Qemu-devel] [PATCH v3 0/4]
Changes from v2:
Patch 1: Fixed prototype for id_generate() (thanks Alberto)
Used *const instead of * const (thanks Eric, Markus) Updated function comment (thanks Markus)
Made random in range 0-99 instead of 0-98 (thanks, Marksu)
Patch 2: Cleaned up comments (thanks Markus)
use else if instead of nested if (thanks Markus) assign node_name on same line as gen_node_name (thanks Markus)
Patch 3,4: new - fix iotests (thanks Kevin)
Changes from RFC v1:
Patch 1: Several typos / grammatical errors (thanks Eric, John)
Make id_subsys_str[] const pointer to const strings (thanks Eric) Moved id_subsys_str[] out from id_generate() (thanks John) Assert on null string for given id (thanks Eric) Zero-pad the 2-digit random # (thanks John)
Patch 2: None
Born from the conversation on qemu-devel, this generation scheme uses the format ultimately proposed by Kevin, after list discussion.
It attempts to keep the ID strings as small as possible, while fulfilling:
1.) Guarantee no collisions with a user-specified ID
2.) Identify the sub-system the ID belongs to
3.) Guarantee of uniqueness
4.) Spoiling predictibility, to avoid creating an assumption
of object ordering and parsing (i.e., we don't want users to think they can guess the next ID based on prior behavior).
See patch 1 for the generation scheme details.
Jeff Cody (4):
util - add automated ID generation utility
block: auto-generated node-names
block: add filter for generated node-names
qemu-iotests: update tests for generated node-names
block.c | 19 ++++++++++++------- include/qemu-common.h | 8 ++++++++ tests/qemu-iotests/041 | 4 ++-- tests/qemu-iotests/051 | 3 ++- tests/qemu-iotests/051.out | 2 +- tests/qemu-iotests/067 | 3 ++- tests/qemu-iotests/067.out | 5 +++++ tests/qemu-iotests/081 | 3 ++- tests/qemu-iotests/081.out | 2 +- tests/qemu-iotests/common.filter | 5 +++++ util/id.c | 37 +++++++++++++++++++++++++++++++++++++ 11 files changed, 77 insertions(+), 14 deletions(-)
Signature · 1 line
1.9.3