Skip to content

watchdog: Sysfs status read support

Pratyush Anand linux-api linux-watchdog lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 8 repliesIn review
  2. v42 patches 3 repliesSuperseded
  3. v32 patches 2 repliesSuperseded

Changes in v5 from the cover letter

* All sysfs code has been protected under CONFIG_WATCHDOG_SYSFS

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2watchdog: Use static struct class watchdog_class in stead of pointerdrivers/watchdog/watchdog_core.c drivers/watchdog/watchdog_core.h drivers/watchdog/watchdog_dev.c+25 -185 replies
2/2watchdog: Read device status through sysfs attributesDocumentation/ABI/testing/sysfs-class-watchdog drivers/watchdog/Kconfig drivers/watchdog/watchdog_core.c +1 more+173 -11 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchGuenter Roeck
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH V5 0/2] watchdog: Sysfs status read support

These patches provide support to read different watchdog device status through sysfs interface.

Changes since V4:
* All sysfs code has been protected under CONFIG_WATCHDOG_SYSFS

Changes since V3:
* Added Reviewed by tag
* Corrected a checkpatch warning

Changes since V2:
* Used static struct class watchdog_class in stead of pointer. It helped to keep using device_create().
* Above logic was moved to a separate patch. Changed subject line of other patch to look more relevant

Changes since V1(RFC):
* Removed keepalive and start ABI
* timeout is read only now
* state returns text
* only supported ABI visible
* ABI contact changed to MAINTAINER
* unnecessary mutex removed
* aligned continuation with '('
* unnecessary initialization of status (= 0) corrected
* unnecessary else removed
* used __ATTRIBUTE_GROUPS
* removed watchdog_device_create and added functionality in
* watchdog_dev_register.
* optimized nowayout_show
* Now no -EOPNOTSUPP return for timeout read in case of
* wdd->timeout = 0.

Pratyush Anand (2):
watchdog: Use static struct class watchdog_class in stead of pointer
watchdog: Read device status through sysfs attributes

 Documentation/ABI/testing/sysfs-class-watchdog |  51 +++++++++
 drivers/watchdog/Kconfig                       |   7 ++
 drivers/watchdog/watchdog_core.c               |  17 +--
 drivers/watchdog/watchdog_core.h               |   2 +-
 drivers/watchdog/watchdog_dev.c                | 140 ++++++++++++++++++++++++-
 5 files changed, 198 insertions(+), 19 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-class-watchdog
Signature · 1 line
2.5.0