Skip to content

qapi-flattening and preparation of -audiodev option

Kővágó, Zoltán qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v17 patches 10 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3qapi: convert NumaOptions into a flat unionnuma.c qapi-schema.json+39 -122 replies
2/3qapi: change NetLegacy into a flat unionnet/net.c qapi-schema.json+44 -320 replies
3/3qapi: support nested structs in OptsVisitorqapi/opts-visitor.c tests/qapi-schema/qapi-schema-test.json tests/qapi-schema/qapi-schema-test.out +1 more+141 -220 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchEric Blake
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/3] qapi-flattening and preparation of -audiodev option

Here is the second version of my qapi flattening attempts. This is now based on Eric Blake's "post-introspection cleanups, and qapi-ify netdev_add" patch series[1], which contains some of my previous commits.

What remains here: NumaOptions flattening (with proposed documentation changes from Eduardo) and OptsVisitor. The Netdev part was mostly taken care of by Eric, I only had to convert NetLegacy into a flat union.

Please review.

[1]: http://lists.nongnu.org/archive/html/qemu-devel/2015-09/msg05410.html

Kővágó, Zoltán (3):
qapi: convert NumaOptions into a flat union
qapi: change NetLegacy into a flat union
qapi: support nested structs in OptsVisitor

 net/net.c                               |  47 +++++++------
 numa.c                                  |   2 +-
 qapi-schema.json                        |  78 +++++++++++++++------
 qapi/opts-visitor.c                     | 116 ++++++++++++++++++++++++++------
 tests/qapi-schema/qapi-schema-test.json |   9 ++-
 tests/qapi-schema/qapi-schema-test.out  |   4 ++
 tests/test-opts-visitor.c               |  34 ++++++++++
 7 files changed, 224 insertions(+), 66 deletions(-)
Signature · 1 line
2.5.2