Skip to content

x86: NMI vs paravirt fixes

Andy Lutomirski lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2x86/paravirt: Replace the paravirt nop with a bona fide empty functionarch/x86/entry/entry_64.S arch/x86/kernel/paravirt.c+23 -40 replies
2/2x86/nmi/64: Fix a paravirt stack-clobbering bug in the NMI codearch/x86/entry/entry_64.S+4 -10 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchSasha Levin
1/2Reported-and-tested-by
2/2Reported-and-tested-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] x86: NMI vs paravirt fixes

These are for x86/urgent.

This fixes at least one problem that Sasha can trigger using some crazy configuration + Trinity. I can't reproduce the full file of nastiness that he's seeing, but these patches both look legit to me, they fix what look like real bugs, and they seem to help Sasha's tests.

Patch 1 is ugly. Feel free to tell me to shove the asm into the entry asm files, although that will involve duplicating it for 32-bit and 64-bit kernels.

Andy Lutomirski (2):
x86/paravirt: Replace the paravirt nop with a bona fide empty function x86/nmi/64: Fix a paravirt stack-clobbering bug in the NMI code

 arch/x86/entry/entry_64.S  | 16 +++++++++++++++-
 arch/x86/kernel/paravirt.c | 16 ++++++++++++----
 2 files changed, 27 insertions(+), 5 deletions(-)
Signature · 1 line
2.4.3