Skip to content

RDS: RDS-TCP perf enhancements

Sowmini Varadhan lkml netdev 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v13 patches 9 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3RDS: Use a single TCP socket for both send and receive.net/rds/connection.c net/rds/rds.h net/rds/tcp_listen.c+18 -300 replies
2/3RDS-TCP: Do not bloat sndbuf/rcvbuf in rds_tcp_tunenet/rds/tcp.c+4 -120 replies
3/3RDS-TCP: Set up MSG_MORE and MSG_SENDPAGE_NOTLAST as appropriate in rds_tcp_xmitnet/rds/tcp_send.c+7 -10 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSantosh Shilimkar
SeriesA-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 net-next 0/3] RDS: RDS-TCP perf enhancements

A 3-part patchset that (a) improves current RDS-TCP perf by 2X-3X and (b) refactors earlier robustness code for better observability/scaling.

Patch 1 is an enhancment of earlier robustness fixes that had used separate sockets for client and server endpoints to resolve race conditions. It is possible to have an equivalent solution that does not use 2 sockets. The benefit of a single socket solution is that it results in more predictable and observable behavior for the underlying TCP pipe of an RDS connection

Patches 2 and 3 are simple, straightforward perf bug fixes that align the RDS TCP socket with other parts of the kernel stack.

v2: fix kbuild-test-robot warnings, comments from Sergei Shtylov
and Santosh Shilimkar.

Sowmini Varadhan (3):
Use a single TCP socket for both send and receive. Do not bloat sndbuf/rcvbuf in rds_tcp_tune
Set up MSG_MORE and MSG_SENDPAGE_NOTLAST as appropriate in
rds_tcp_xmit

 net/rds/connection.c |   22 ++++++----------------
 net/rds/rds.h        |    4 +++-
 net/rds/tcp.c        |   16 ++++------------
 net/rds/tcp_listen.c |   22 +++++++++-------------
 net/rds/tcp_send.c   |    8 +++++++-
 5 files changed, 29 insertions(+), 43 deletions(-)