Skip to content

Modify ida_* users to use ida_simple_*

Lee Duncan linux-nvme linux-scsi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5SCSI: sd: simplify ida usagedrivers/scsi/sd.c+5 -171 reply
2/5block: rsxx: core: simplify ida usagedrivers/block/rsxx/core.c+4 -161 reply
3/5block: nvme-core: simplify ida usagedrivers/block/nvme-core.c+4 -122 replies
4/5block: mtip32xx: simplify ida usagedrivers/block/mtip32xx/mtip32xx.c+6 -201 reply
5/5base: soc: siplify ida usagedrivers/base/soc.c+5 -161 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJohannes ThumshirnTejun Heo
SeriesR-b
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] Modify ida_* users to use ida_simple_*

The ida index management routines are used in several driver modules to manage allocation and release of index values. Reviewing the way in which the ida routines were called, together with the small number of such clients, led to the belief that these users should all be able to share a simple built-in lock in the ida module by calling the ida_simple_*() functions instead of the non-simple versions. This means that ida does all the required locking so that clients don't have to manage that.

This will greatly simplify the client calling code, and if there is any problem with these clients sharing a "simple" lock, the ida code can be transparently expanded to allocate a lock per client, without having to change any of the clients again.

NOTE: this patch series replaces an earlier attempt to create a new set of ida helper functions titled:

"Create and use ida and idr helper routines"

Another set will soon be sent out soon to (1) add idr helper functions, (2) modify clients to use them, and (3) update SCSI host_no to use them.

Lee Duncan (5):
SCSI: sd: simplify ida usage
block: rsxx: core: simplify ida usage
block: nvme-core: simplify ida usage
block: mtip32xx: simplify ida usage
base: soc: siplify ida usage

 drivers/base/soc.c                | 21 +++++----------------
 drivers/block/mtip32xx/mtip32xx.c | 26 ++++++--------------------
 drivers/block/nvme-core.c         | 16 ++++------------
 drivers/block/rsxx/core.c         | 20 ++++----------------
 drivers/scsi/sd.c                 | 22 +++++-----------------
 5 files changed, 24 insertions(+), 81 deletions(-)
Signature · 1 line
2.1.4