Skip to content

Fix most sparse warnings

Mauro Carvalho Chehab linux-arm-kernel linux-media linux-samsung-soc 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7media-entity.c: get rid of var length arraysdrivers/media/media-entity.c include/media/media-entity.h+9 -20 replies
2/7s5c73m3: fix a sparse warningdrivers/media/i2c/s5c73m3/s5c73m3-core.c+1 -10 replies
3/7netup_unidvb: remove most of the sparse warningsdrivers/media/pci/netup_unidvb/netup_unidvb.h drivers/media/pci/netup_unidvb/netup_unidvb_ci.c drivers/media/pci/netup_unidvb/netup_unidvb_core.c +2 more+12 -140 replies
4/7netup_unidvb_ci: Fix dereference of noderef expressiondrivers/media/pci/netup_unidvb/netup_unidvb_ci.c+4 -40 replies
5/7mipi-csis: make sparse happydrivers/media/platform/exynos4-is/mipi-csis.c+2 -14 replies
6/7c8sectpfe: fix namespace on memcpy/memsetdrivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c+2 -21 reply
7/7rcar_jpu: Fix namespace for two __be16 varsdrivers/media/platform/rcar_jpu.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] Fix most sparse warnings

There are still some sparse warnings. None of them are currently real bug, but they make sparse to be confused, and namespaces are not properly used. That could hide bug on some future change.

So, fix them. After this series, there are just 2 sparse warnings:

drivers/media/platform/timblogiw.c:562:22: warning: context imbalance in 'buffer_queue' - unexpected unlock drivers/media/platform/soc_camera/rcar_vin.c:835:25: warning: context imbalance in 'rcar_vin_wait_stop_streaming' - unexpected unlock

Both are OK, but I dunno how to shut up sparse to report them. If anyone has an idea, feel free to send a patch ;)

Mauro Carvalho Chehab (7):
[media] media-entity.c: get rid of var length arrays [media] s5c73m3: fix a sparse warning
[media] netup_unidvb: remove most of the sparse warnings [media] netup_unidvb_ci: Fix dereference of noderef expression [media] mipi-csis: make sparse happy
[media] c8sectpfe: fix namespace on memcpy/memset [media] rcar_jpu: Fix namespace for two __be16 vars

 drivers/media/i2c/s5c73m3/s5c73m3-core.c              |  2 +-
 drivers/media/media-entity.c                          |  4 ++--
 drivers/media/pci/netup_unidvb/netup_unidvb.h         |  4 ++--
 drivers/media/pci/netup_unidvb/netup_unidvb_ci.c      | 10 +++++-----
 drivers/media/pci/netup_unidvb/netup_unidvb_core.c    | 14 ++++++--------
 drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c     |  2 +-
 drivers/media/pci/netup_unidvb/netup_unidvb_spi.c     |  4 ++--
 drivers/media/platform/exynos4-is/mipi-csis.c         |  3 ++-
 drivers/media/platform/rcar_jpu.c                     |  4 ++--
 drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c |  4 ++--
 include/media/media-entity.h                          |  7 +++++++
 11 files changed, 32 insertions(+), 26 deletions(-)
Signature · 1 line
2.4.3