Skip to content

staging: iio: adc: fix multiple checkpatch issues

Ioana Ciornei outreachy 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest9 patches 10 repliesIn review
  2. v39 patches 19 repliesSuperseded
  3. v29 patches 7 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v110 patches8 repliesSuperseded

Changes in v4 from the cover letter

- reworked patch 2/9 in order to follow kernel coding style
- changed patch 5/9 in order to not break user space
- reworked patch 8/9 because abbreviations are not considered camel case
- changed patch 9/9 by moving block comment above the macro def

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9staging: iio: adc: use kernel types u32 and u64drivers/staging/iio/adc/mxs-lradc.c+15 -151 reply
2/9staging: iio: adc: properly indent to match open paranthesisdrivers/staging/iio/adc/ad7192.c drivers/staging/iio/adc/ad7280a.c drivers/staging/iio/adc/ad7606_core.c +7 more+249 -2231 reply
3/9staging: iio: adc: remove explicit comparison to NULLdrivers/staging/iio/adc/ad7192.c drivers/staging/iio/adc/ad7280a.c drivers/staging/iio/adc/mxs-lradc.c+6 -61 reply
4/9staging: iio: adc: remove space after castdrivers/staging/iio/adc/ad7192.c drivers/staging/iio/adc/ad7280a.c drivers/staging/iio/adc/ad7606_core.c +1 more+7 -71 reply
5/9staging: iio: adc: add spaces around binary operatorsdrivers/staging/iio/adc/ad7816.c+1 -11 reply
6/9staging: iio: adc: add blank line after declarationsdrivers/staging/iio/adc/ad7606_par.c drivers/staging/iio/adc/ad7606_spi.c+2 -01 reply
7/9staging: iio: adc: remove multiple blank linesdrivers/staging/iio/adc/ad7192.c drivers/staging/iio/adc/ad7280a.c drivers/staging/iio/adc/ad7780.c +1 more+0 -61 reply
8/9staging: iio: adc: remove the use of CamelCasedrivers/staging/iio/adc/ad7192.c drivers/staging/iio/adc/ad7192.h drivers/staging/iio/adc/ad7280a.c+8 -81 reply
9/9staging: iio: adc: properly indent block commentsdrivers/staging/iio/adc/ad7192.c+25 -102 replies

Reviews trailers per patch

8 of 9 patches have a Reviewed-by or Acked-by.

PatchDaniel Baluta
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/9] staging: iio: adc: fix multiple checkpatch issues

This patchset fixes multiple checkpatch issues.

Changes in v2:
- removed commit 09/10 from previous version since it introduced build warnings

Changes in v3:
- reworked patch 2/9 so that it does not introduce any other checkpatch warnings
- changed the cover letter description in order to keep up with the other updates

Changes in v4:
- reworked patch 2/9 in order to follow kernel coding style
- changed patch 5/9 in order to not break user space
- reworked patch 8/9 because abbreviations are not considered camel case
- changed patch 9/9 by moving block comment above the macro def

Ioana Ciornei (9):
staging: iio: adc: use kernel types u32 and u64
staging: iio: adc: properly indent to match open paranthesis
staging: iio: adc: remove explicit comparison to NULL
staging: iio: adc: remove space after cast
staging: iio: adc: add spaces around binary operators
staging: iio: adc: add blank line after declarations
staging: iio: adc: remove multiple blank lines
staging: iio: adc: remove the use of CamelCase
staging: iio: adc: properly indent block comments

 drivers/staging/iio/adc/ad7192.c      |  97 ++++++++++--------
 drivers/staging/iio/adc/ad7192.h      |   2 +-
 drivers/staging/iio/adc/ad7280a.c     | 178 ++++++++++++++++----------------
 drivers/staging/iio/adc/ad7606_core.c |  23 +++--
 drivers/staging/iio/adc/ad7606_par.c  |  15 +--
 drivers/staging/iio/adc/ad7606_spi.c  |   5 +-
 drivers/staging/iio/adc/ad7780.c      |  13 +--
 drivers/staging/iio/adc/ad7816.c      |  53 +++++-----
 drivers/staging/iio/adc/lpc32xx_adc.c |  14 +--
 drivers/staging/iio/adc/mxs-lradc.c   | 185 +++++++++++++++++++---------------
 drivers/staging/iio/adc/spear_adc.c   |   4 +-
 11 files changed, 313 insertions(+), 276 deletions(-)
Signature · 1 line
2.1.4