Skip to content

toaster: Implement UI changes for "command line builds" project

Ed Bartosh bitbake-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 1 replyIn review

Changes in v1 from the cover letter

* One of the changes in the design document has not been implemented:
it's not possible to hide the "customise image recipe" links and buttons (page 9) as these are not in the templates yet.

* The visual design differs slightly from the design document, as it incorporates a new layout for the build dashboard which is not implemented yet.

* The "New build" button is displayed on the command line builds project page, as we came to the conclusion that the logic in the JavaScript (i.e. show the new build button if there is no build input form on the page) should apply in the case of the builds page for the "command line builds" project.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10toaster: Reorganise and lint testslib/toaster/toastergui/tests.py+49 -340 replies
2/10toaster: Replace "Run again" button with help text for cli buildslib/toaster/toastergui/static/css/default.css lib/toaster/toastergui/templates/mrb_section.html lib/toaster/toastergui/tests.py+64 -140 replies
3/10toaster: Show 'not applicable' for default project machine and releaselib/toaster/toastergui/templates/projects.html lib/toaster/toastergui/tests.py+111 -130 replies
4/10toaster: Make the builds view the project page for "command line builds"lib/toaster/toastergui/templates/base.html lib/toaster/toastergui/templates/builds.html lib/toaster/toastergui/templates/mrb_section.html +3 more+82 -110 replies
5/10toaster: Hide tabs and add info popups for command line buildslib/toaster/toastergui/static/js/base.js lib/toaster/toastergui/templates/mrb_section.html lib/toaster/toastergui/templates/projecttopbar.html +1 more+94 -430 replies
6/10toaster: Show tooltip next to cli builds project name in all buildslib/toaster/toastergui/templates/builds.html lib/toaster/toastergui/templates/mrb_section.html lib/toaster/toastergui/tests.py+40 -100 replies
7/10toaster: More linting of testslib/toaster/toastergui/tests.py+14 -210 replies
8/10toaster: Clean up template codelib/toaster/toastergui/templates/builds.html lib/toaster/toastergui/templates/mrb_section.html+10 -160 replies
9/10toaster: Exclude "command line builds" project from projects typeaheadlib/toaster/toastergui/typeaheads.py+2 -20 replies
10/10toaster: Modify "New build" button behaviour for cli builds projectlib/toaster/toastergui/static/js/base.js lib/toaster/toastergui/templates/base.html lib/toaster/toastergui/views.py+59 -510 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] toaster: Implement UI changes for "command line builds" project

Hi,

This implements changes across the UI to hide irrelevant options for command-line builds, and show additional help icons explaining why those options are hidden.

It also modifies the behaviour of the "New build" button to take account of the special status of the command-line builds project.

For UI details, see the document attached to bug 8231 at https://bugzilla.yoctoproject.org/attachment.cgi?id=2760.

v2 (in response to Belen's review):

* Modify how the form for changing the project name is shown, so that the edit buttons aren't lost after saving the new project name. Also verify that project name changes take without requiring a page refresh.

* Never select the command-line builds project in the "New build" drop-down form.

* Only show the "New build" button if there are one or more user-created projects (i.e. not if there is only the command-line builds project).

v1:

* One of the changes in the design document has not been implemented:
it's not possible to hide the "customise image recipe" links and buttons (page 9) as these are not in the templates yet.

* The visual design differs slightly from the design document, as it incorporates a new layout for the build dashboard which is not implemented yet.

* The "New build" button is displayed on the command line builds project page, as we came to the conclusion that the logic in the JavaScript (i.e. show the new build button if there is no build input form on the page) should apply in the case of the builds page for the "command line builds" project.

The following changes since commit 64680eb3a2eef5e6cf46c18f712b319edb1fc78a:

toaster: remove bashisms so script works in dash as well (2015-10-07 15:06:40 +0300)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/toaster/submit/elliot/toaster/cli_builds_ui-8231
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/submit/elliot/toaster/cli_builds_ui-8231

Elliot Smith (10):
toaster: Reorganise and lint tests
toaster: Replace "Run again" button with help text for cli builds
toaster: Show 'not applicable' for default project machine and release
toaster: Make the builds view the project page for "command line
builds"
toaster: Hide tabs and add info popups for command line builds
toaster: Show tooltip next to cli builds project name in all builds
toaster: More linting of tests
toaster: Clean up template code
toaster: Exclude "command line builds" project from projects typeahead
toaster: Modify "New build" button behaviour for cli builds project

 lib/toaster/toastergui/static/css/default.css      |   5 +
 lib/toaster/toastergui/static/js/base.js           |  18 +-
 lib/toaster/toastergui/templates/base.html         |  98 ++++---
 lib/toaster/toastergui/templates/builds.html       |  19 +-
 lib/toaster/toastergui/templates/mrb_section.html  |  66 +++--
 lib/toaster/toastergui/templates/projects.html     |  23 +-
 .../toastergui/templates/projecttopbar.html        |  80 ++---
 .../toastergui/templatetags/project_url_tag.py     |  34 +++
 lib/toaster/toastergui/tests.py                    | 322 ++++++++++++++++++---
 lib/toaster/toastergui/typeaheads.py               |   4 +-
 lib/toaster/toastergui/views.py                    |   9 +-
 11 files changed, 494 insertions(+), 184 deletions(-)
 create mode 100644 bitbake/lib/toaster/toastergui/templatetags/project_url_tag.py
Signature · 1 line
2.1.4