Skip to content

toaster: Improve display of errors and Toaster exceptions

Ed Bartosh bitbake-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4toaster: Record critical errorslib/bb/ui/buildinfohelper.py lib/bb/ui/toasterui.py lib/toaster/orm/models.py +1 more+25 -130 replies
2/4toaster: Remove Toaster exceptions section of build dashboardlib/toaster/orm/models.py lib/toaster/toastergui/templates/builddashboard.html+4 -450 replies
3/4toaster: Guard against builds with no targetslib/toaster/toastergui/templates/builddashboard.html+7 -20 replies
4/4toaster: Add tests for error message display on the build dashboardlib/toaster/toastergui/tests.py+89 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] toaster: Improve display of errors and Toaster exceptions

Hi,

Fixes recording of error messages so that CRITICAL errors are properly logged and presented to the user.

Modifies how Toaster exceptions are displayed, so they are treated the same way as other classes of ERROR.

The following changes since commit a8e82d93bfa8feb722912d03ee26bbad7e6fe9f7:

toaster: Modify "New build" button behaviour for cli builds project (2015-10-15 14:54:27 +0300)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/toaster/submit/elliot/toaster/error_display-8320
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/submit/elliot/toaster/error_display-8320

Elliot Smith (4):
toaster: Record critical errors
toaster: Remove Toaster exceptions section of build dashboard
toaster: Guard against builds with no targets
toaster: Add tests for error message display on the build dashboard

 lib/bb/ui/buildinfohelper.py                       |  5 +-
 lib/bb/ui/toasterui.py                             |  2 +
 lib/toaster/orm/models.py                          | 24 +++---
 .../toastergui/templates/builddashboard.html       | 47 ++---------
 lib/toaster/toastergui/tests.py                    | 91 +++++++++++++++++++++-
 5 files changed, 116 insertions(+), 53 deletions(-)

--
Regards,
Ed