Skip to content

Add mixer and control interface media entities

Shuah Khan alsa-devel linux-media 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 0 repliesNew
  2. v23 patches 5 repliesSuperseded
  3. v12 patches 0 repliesSuperseded

Changes in v3 from the cover letter

1. Addressed Takashi's comments on the following ALSA patch:
sound/usb: Create media mixer function and control interface entities
2. Include patches to fix compile warnings found by kbuild bot, and an additional fix in media stream cleanup path.
3. No changes to patches 1 and 3.
4. Changed patches: 2
5. New patches: 4,5, and 6

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6sound/usb: Fix media_stream_delete() to remove intf devnodesound/usb/media.c+1 -00 replies
2/6sound/usb: Create media mixer function and control interface entitiessound/usb/card.c sound/usb/media.c sound/usb/media.h +2 more+119 -00 replies
3/6media: au0828 create link between ALSA Mixer and decoderdrivers/media/usb/au0828/au0828-core.c drivers/media/usb/au0828/au0828.h+15 -30 replies
4/6sound/usb: Fix media_stream_init() and media_stream_delete() error pathssound/usb/media.c+6 -30 replies
5/6media: Fix compile warning when CONFIG_MEDIA_CONTROLLER_DVB is disableddrivers/media/dvb-core/dvb_frontend.c+1 -10 replies
6/6media: au0828-core fix ignoring return value errorsdrivers/media/usb/au0828/au0828-core.c+16 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH MC Next Gen v3 0/6] Add mixer and control interface media entities

This patch v3 series adds the following:

A fix to media_stream_delete() to remove intf devnode.

Add support for creating MEDIA_ENT_F_AUDIO_MIXER entity for each mixer and a MEDIA_INTF_T_ALSA_CONTROL control interface entity that links to mixer entities. MEDIA_INTF_T_ALSA_CONTROL entity corresponds to the control device for the card.

Change au0828_create_media_graph() to create pad link between MEDIA_ENT_F_AUDIO_MIXER entity and decoder's AU8522_PAD_AUDIO_OUT. With mixer entity now linked to decoder, change to link MEDIA_ENT_F_AUDIO_CAPTURE to mixer's source pad

In addition, this patch series consists of fixes to compile warnings found by kbuild bot, and an additional fix in media stream cleanup path.

Changes since v2:

1. Addressed Takashi's comments on the following ALSA patch:
sound/usb: Create media mixer function and control interface entities
2. Include patches to fix compile warnings found by kbuild bot, and an additional fix in media stream cleanup path.
3. No changes to patches 1 and 3.
4. Changed patches: 2
5. New patches: 4,5, and 6

Changes since v1:
1. Included the fix to media_stream_delete() which was by mistake not included in the patch v1.
2. Fixed mixer to decoder link and mixer to capture node links based on Mauro Chehab's review comments on the media graph.

This patch series is dependent on an earlier patch series-es:

Patch series v2:
https://www.mail-archive.com/[email protected]/msg93084.html

Patch series v1:
Update ALSA, and au0828 drivers to use Managed Media Controller API:
https://www.mail-archive.com/[email protected]/msg92752.html

Please find the media graphs for ALSA work with mixer and control interface nodes: (these are generated using mc_next_gen_test tool.

https://drive.google.com/folderview?id=0B0NIL0BQg-AlLWE3SzAxazBJWm8&usp=sharing

v4l2-utils patch adds mixer node support mc_next_gen_test tool:
https://www.mail-archive.com/[email protected]/msg93086.html

Shuah Khan (6):
sound/usb: Fix media_stream_delete() to remove intf devnode sound/usb: Create media mixer function and control interface entities
media: au0828 create link between ALSA Mixer and decoder sound/usb: Fix media_stream_init() and media_stream_delete() error
paths
media: Fix compile warning when CONFIG_MEDIA_CONTROLLER_DVB is
disabled
media: au0828-core fix ignoring return value errors

 drivers/media/dvb-core/dvb_frontend.c  |   2 +-
 drivers/media/usb/au0828/au0828-core.c |  38 +++++++++---
 drivers/media/usb/au0828/au0828.h      |   1 +
 sound/usb/card.c                       |   5 ++
 sound/usb/media.c                      | 102 ++++++++++++++++++++++++++++++++-
 sound/usb/media.h                      |  20 +++++++
 sound/usb/mixer.h                      |   1 +
 sound/usb/usbaudio.h                   |   1 +
 8 files changed, 158 insertions(+), 12 deletions(-)
Signature · 1 line
2.5.0