staging: r8723au: fix multiple checkpatch issues
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 7 repliesIn review
- v15 patches 8 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | staging: r8723au: break parameter list at separators and align to open bracesdrivers/ | +38 | 4 replies | |
| 2/5 | staging: r8723au: replace printk() with netdev_err()drivers/ | +2 | 0 replies | |
| 3/5 | staging: r8723au: move constant to right of comparison testdrivers/ | +1 | 0 replies | |
| 4/5 | staging: r8723au: add & use local variable to simplify referencesdrivers/ | +6 | 0 replies | |
| 5/5 | staging: r8723au: use kernel preferred style for commentingdrivers/ | +80 | 3 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/5] staging: r8723au: fix multiple checkpatch issues
This patchset addresses the last 26 checkpatch WARNINGs in file:drivers/staging/rtl8723au/core/rtw_cmd.c
I'll call your attention to the "Line over 80 chars" cases:
I chose to address 'Line over 80 chars' because all but one could be resolved by cleaning up a single struct definition. [PATCH 1/5]
The last one appeared to be due to excessively long function names as opposed to deep indentation/complex code requiring refactoring. See my notes below the --- in PATCH[4/5] for further info.
alison
Changes in v2:
The patches have been reordered.
The comment corrections are now the last patch in the series.
[1/5] no changes
[2/5] now using netdev_err per reviewer feedback
[3/5] no change in code, but the diff changed when I moved the comment patch. [4/5] no change in code, but same as above, diff appears a bit 'different.' [5/5] scanned and corrected comments thru entire file, not just those
reported by checkpatch (ie. spacing issues)
Alison Schofield (5):
staging: r8723au: break parameter list at separators and align to open
braces
staging: r8723au: replace printk() with netdev_err()
staging: r8723au: move constant to right of comparison test
staging: r8723au: add & use local variable to simplify references
staging: r8723au: use kernel preferred style for commenting
drivers/staging/rtl8723au/core/rtw_cmd.c | 239 ++++++++++++++++--------------- 1 file changed, 127 insertions(+), 112 deletions(-)
Signature · 1 line
2.1.4