Skip to content

staging: r8723au: clean up in file rtw_ap.c

Alison Schofield outreachy 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4staging: r8723au: use kernel preferred style for commentingdrivers/staging/rtl8723au/core/rtw_ap.c+89 -630 replies
2/4staging: r8723au: move params to new line to improve readabilitydrivers/staging/rtl8723au/core/rtw_ap.c+52 -260 replies
3/4staging: r8723au: replace explicit NULL comparisons with !drivers/staging/rtl8723au/core/rtw_ap.c+4 -40 replies
4/4staging: r8723au: remove externs and include needed header filedrivers/staging/rtl8723au/core/rtw_ap.c+1 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] staging: r8723au: clean up in file rtw_ap.c

This patchset reduces the checkpatch warnings by 43 in rtw_ap.c

Patch 1: It begins with a clean sweep of the comments to improve
readability & reduce CP errs. (apologies in advance for any patch review fatigue this induces ;)

Patch 2: Addresses the simple line over 80 cases where params
could be moved to the next line.

Patch 3: Simplifies one NULL comparison

Patch 4: Removes extern declarations & adds a header file include.

This file still contains 30 checkpatch errs (mostly lines > 80) and some extra long functions.

Alison Schofield (4):
staging: r8723au: use kernel preferred style for commenting
staging: r8723au: move params to new line to improve readability
staging: r8723au: replace explicit NULL comparisons with !
staging: r8723au: remove externs and include needed header file

 drivers/staging/rtl8723au/core/rtw_ap.c | 243 +++++++++++++++++++-------------
 1 file changed, 146 insertions(+), 97 deletions(-)
Signature · 1 line
2.1.4