Skip to content

toaster: 8279: Provide a single way of starting Toaster

Ed Bartosh yocto-toaster 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest30 patches 1 replyIn review
  2. v527 patches 4 repliesSuperseded
  3. v426 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v125 patches4 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/30toaster: don't allow to run toaster as a scriptbitbake/bin/toaster+5 -750 replies
2/30toaster: implement get-dburl commandbitbake/lib/toaster/toastermain/management/commands/get-dburl.py+9 -00 replies
3/30toaster: set DATABASE_URL in toaster scriptbitbake/bin/toaster+1 -00 replies
4/30toaster: run bitbake the same waybitbake/bin/toaster+4 -60 replies
5/30toaster: remove unused variablebitbake/bin/toaster+0 -20 replies
6/30toaster: check for toaster configuration laterbitbake/bin/toaster+24 -10 replies
7/30toaster: use parent of the build dirbitbake/bin/toaster+1 -10 replies
8/30toaster: make runbuilds to loopbitbake/lib/toaster/bldcontrol/management/commands/runbuilds.py+10 -30 replies
9/30toaster: start 'manage.py runbuilds' in the scriptbitbake/bin/toaster+2 -10 replies
10/30toaster: update brbe and project attributesbitbake/lib/bb/ui/buildinfohelper.py+6 -00 replies
11/30toaster: implement stop_bitbake functionbitbake/bin/toaster+8 -40 replies
12/30toaster: implement start_bitbake functionbitbake/bin/toaster+18 -150 replies
13/30toaster: implement 'toaster restart-bitbake'bitbake/bin/toaster+9 -00 replies
14/30toaster: remove _setupBE functionbitbake/lib/toaster/bldcontrol/localhostbecontroller.py+2 -170 replies
15/30toaster: reimplemented startBBServer methodbitbake/lib/toaster/bldcontrol/localhostbecontroller.py+18 -720 replies
16/30toaster: remove stopBBServer APIbitbake/lib/toaster/bldcontrol/bbcontroller.py bitbake/lib/toaster/bldcontrol/localhostbecontroller.py bitbake/lib/toaster/bldcontrol/sshbecontroller.py +1 more+0 -290 replies
17/30toaster: do not terminate bb serverbitbake/lib/bb/ui/toasterui.py+5 -90 replies
18/30toaster: remove usage of BUILD_MODE variablebitbake/lib/toaster/toastergui/templates/base.html bitbake/lib/toaster/toastergui/templates/landing.html bitbake/lib/toaster/toastergui/tests.py +3 more+5 -500 replies
19/30toaster: do not create duplicate HelpText objectsbitbake/lib/bb/ui/buildinfohelper.py+3 -70 replies
20/30toaster: buildinfohelper Broaden the toaster created recipe data casebitbake/lib/bb/ui/buildinfohelper.py+3 -40 replies
21/30toaster: implement BitbakeController.getVariablebitbake/lib/toaster/bldcontrol/bbcontroller.py+3 -00 replies
22/30toaster: set varibales on bitbake serverbitbake/lib/toaster/bldcontrol/localhostbecontroller.py+9 -20 replies
23/30toaster: remove writeConfFile APIbitbake/lib/toaster/bldcontrol/bbcontroller.py bitbake/lib/toaster/bldcontrol/localhostbecontroller.py+0 -170 replies
24/30toaster: stop using toaster-pre.confbitbake/bin/toaster+1 -20 replies
25/30toaster: remove SDKMACHINE from project variablesbitbake/lib/toaster/toastergui/templates/projectconf.html bitbake/lib/toaster/toastergui/views.py+1 -780 replies
26/30toaster: get rid of complicated heuristicsbitbake/lib/bb/ui/buildinfohelper.py+9 -380 replies
27/30toaster: unset environment variablesbitbake/bin/toaster+4 -00 replies
28/30command: add CommandStarted eventbitbake/lib/bb/command.py+6 -00 replies
29/30bb/ui: ignore CommandStarted eventbitbake/lib/bb/ui/crumbs/runningbuild.py bitbake/lib/bb/ui/knotty.py+4 -20 replies
30/30toasterui: process CommandStarted eventbitbake/lib/bb/ui/toasterui.py+7 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH v6 00/30] toaster: 8279: Provide a single way of starting Toaster

This patchset merges two Toaster modes in one:

To run toaster you should source it in already prepared build environment:
cd poky
. oe-init-build-env
. ../bitbake/bin/toaster

After that you should be able to trigger builds both ways:
from command line and from toaster UI.

Please note that you need to also apply these 2 patches:
https://lists.yoctoproject.org/pipermail/toaster/2015-November/003254.html
They're logically belong to this patchset, but the upstream for them is different, so I decided to send them separately.

Please review and test.

Changes in v4: Removed buildinfohelper code which was trying to guess layer
version of the recipe. As a result of this bug Toaster UI was not showing any information about recipes.

Changes in v5: Rebased on top of latest toaster-next.
Unset environment variables when toaster stops

Changes in v6: Fixed handling of parsing failures https://bugzilla.yoctoproject.org/show_bug.cgi?id=8279#c25

The following changes since commit c68c75e946fb166d8e7b42fb5da4f50917924095:

toaster: change toasterconf.json logic to use TEMPLATECONF, like oe-setup-builddir (2015-11-23 11:58:16 +0200)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/toaster/8279-v6
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/8279-v6

Ed Bartosh (29):
toaster: don't allow to run toaster as a script
toaster: implement get-dburl command
toaster: set DATABASE_URL in toaster script
toaster: run bitbake the same way
toaster: remove unused variable
toaster: check for toaster configuration later
toaster: use parent of the build dir
toaster: make runbuilds to loop
toaster: start 'manage.py runbuilds' in the script
toaster: update brbe and project attributes
toaster: implement stop_bitbake function
toaster: implement start_bitbake function
toaster: implement 'toaster restart-bitbake'
toaster: remove _setupBE function
toaster: reimplemented startBBServer method
toaster: remove stopBBServer API
toaster: do not terminate bb server
toaster: remove usage of BUILD_MODE variable
toaster: do not create duplicate HelpText objects
toaster: implement BitbakeController.getVariable
toaster: set varibales on bitbake server
toaster: remove writeConfFile API
toaster: stop using toaster-pre.conf
toaster: remove SDKMACHINE from project variables
toaster: get rid of complicated heuristics
toaster: unset environment variables
command: add CommandStarted event
bb/ui: ignore CommandStarted event
toasterui: process CommandStarted event

Michael Wood (1):
toaster: buildinfohelper Broaden the toaster created recipe data case

 bitbake/bin/toaster                                | 166 +++++++++------------
 bitbake/lib/bb/command.py                          |   6 +
 bitbake/lib/bb/ui/buildinfohelper.py               |  68 +++------
 bitbake/lib/bb/ui/crumbs/runningbuild.py           |   3 +-
 bitbake/lib/bb/ui/knotty.py                        |   3 +-
 bitbake/lib/bb/ui/toasterui.py                     |  21 +--
 bitbake/lib/toaster/bldcontrol/bbcontroller.py     |  15 +-
 .../toaster/bldcontrol/localhostbecontroller.py    | 140 ++++-------------
 .../bldcontrol/management/commands/runbuilds.py    |  13 +-
 bitbake/lib/toaster/bldcontrol/sshbecontroller.py  |  10 --
 bitbake/lib/toaster/bldcontrol/tests.py            |   4 -
 bitbake/lib/toaster/toastergui/templates/base.html |   9 +-
 .../lib/toaster/toastergui/templates/landing.html  |  10 --
 .../toaster/toastergui/templates/projectconf.html  |  70 +--------
 bitbake/lib/toaster/toastergui/tests.py            |   4 -
 bitbake/lib/toaster/toastergui/views.py            |  29 ----
 .../toastermain/management/commands/get-dburl.py   |   9 ++
 bitbake/lib/toaster/toastermain/settings.py        |   3 -
 bitbake/lib/toaster/toastermain/urls.py            |   9 +-
 19 files changed, 167 insertions(+), 425 deletions(-)
 create mode 100644 bitbake/lib/toaster/toastermain/management/commands/get-dburl.py

--
Regards,
Ed