Skip to content

Don't allow snapshots if the overlay has parent nodes

Alberto Garcia qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2block: Don't allow snapshots if the overlay has parent nodesblockdev.c+5 -00 replies
2/2block: test 'blockdev-snapshot' using a file BDS as the overlaytests/qemu-iotests/085 tests/qemu-iotests/085.out+15 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/2] Don't allow snapshots if the overlay has parent nodes

There are several sanity checks for the 'blockdev-snapshot' command, but none covers the use of a file BDS as the overlay node.

      { 'execute': 'blockdev-add', 'arguments':
        { 'options': { 'driver': 'qcow2',
                       'node-name': 'new0',
                       'file': { 'driver': 'file',
                                 'filename': 'new.qcow2',
                                 'node-name': 'file0' } } } }

      { 'execute': 'blockdev-snapshot', 'arguments':
        { 'node': 'virtio0',
          'overlay': 'file0' } }

This series fixes that and adds a new test case. This of course depends on the 'blockdev-snapshot' series:

https://lists.gnu.org/archive/html/qemu-block/2015-10/msg00974.html

I anyway wonder if it wouldn't be a good idea to have regular op blockers in all file BDSs?

Regards,

Berto

Alberto Garcia (2):
block: Don't allow snapshots if the overlay has parent nodes
block: test 'blockdev-snapshot' using a file BDS as the overlay

 blockdev.c                 |  5 +++++
 tests/qemu-iotests/085     | 12 +++++++++++-
 tests/qemu-iotests/085.out |  4 ++++
 3 files changed, 20 insertions(+), 1 deletion(-)
Signature · 1 line
2.6.1

Read the cover letter in its thread