Skip to content

ARM: Highbank: Highbank: Add monitor support

Peter Crosthwaite qemu-arm qemu-devel 2 versions – Applied

Status from this message: Applied this version to target-arm.next, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 1 replyApplied
  2. v33 patches 5 repliesSuperseded

Changes in v4 from the cover letter

Addressed PMM v2 review
Changed tcg_enabled() checks to kvm_enabled() Changed since v2:
Defeature -cpu for Highbank (new patch) Rework board_setup blob implementation (PMM review) Conditionalise feature on TCG
Dropped initial board_setup and Zynq patches (Merged) Changed since v1:
Addressed PMM review.
Added secure_board_setup flag (P4)
Added Zynq patch first, then Highbank

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/3arm: boot: Add secure_board_setup flaghw/arm/boot.c include/hw/arm/arm.h+15 -10 replies
2/3arm: highbank: Defeature CPU overridehw/arm/highbank.c+7 -140 replies
3/3arm: highbank: Implement PSCI and dummy monitorhw/arm/highbank.c+60 -100 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchPeter Maydell
1/3
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH for-2.5 v4 0/3] ARM: Highbank: Highbank: Add monitor support

Hi,

This adds dummy monitor support to the Highbank board. It is needed by the Highbank kernel which expects a monitor to be present.

A feature is added to arm/boot's board_setup feature, that allows the board_setup entry point to be entered in secure mode (which is needed to configure a monitor).

This feature does not play nice with -cpu override, but cpu override is not valid for well-defined ARM SoCs. So defeature -cpu for Highbank.

Regards,
Peter

See indiv. patches for detailed change logs.

Changed since v3:
Addressed PMM v2 review
Changed tcg_enabled() checks to kvm_enabled() Changed since v2:
Defeature -cpu for Highbank (new patch) Rework board_setup blob implementation (PMM review) Conditionalise feature on TCG
Dropped initial board_setup and Zynq patches (Merged) Changed since v1:
Addressed PMM review.
Added secure_board_setup flag (P4)
Added Zynq patch first, then Highbank

Peter Crosthwaite (3):
arm: boot: Add secure_board_setup flag
arm: highbank: Defeature CPU override
arm: highbank: Implement PSCI and dummy monitor

 hw/arm/boot.c        | 10 +++++-
 hw/arm/highbank.c    | 91 ++++++++++++++++++++++++++++++++++++++--------------
 include/hw/arm/arm.h |  6 ++++
 3 files changed, 82 insertions(+), 25 deletions(-)
Signature · 1 line
1.9.1