Disallow snapshots if the overlay doesn't support backing files
Status from this message: Thanks, applied to the block branch.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 5 repliesApplied
- v22 patches 6 repliesSuperseded
Changes in v3 from the cover letter
- patch 2: new patch to remove all the existing inner quotation marks in test 085 [Max, Eric]
- patch 3: fix description and remove inner quotation marks [Max, Eric]
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | block: Disallow snapshots if the overlay doesn't support backing filesblockdev.c | +5 | 1 reply | |
| 2/3 | block: Remove inner quotation marks in iotest 085tests/ | +8 | 2 replies | |
| 3/3 | block: test 'blockdev-snapshot' using a file BDS as the overlaytests/ tests/ | +15 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake | Max Reitz |
|---|---|---|
| 1/3 | R-b | R-b |
| 2/3 | R-b | |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v3 0/3] Disallow snapshots if the overlay doesn't support backing files
We are currently allowing snapshots in cases like this one:
{ 'execute': 'blockdev-add', 'arguments':
{ 'options': { 'driver': 'qcow2',
'node-name': 'new0',
'file': { 'driver': 'file',
'filename': 'new.qcow2',
'node-name': 'file0' } } } }
{ 'execute': 'blockdev-snapshot', 'arguments':
{ 'node': 'virtio0',
'overlay': 'file0' } }This patch forbids snapshots if the overlay node does not support backing files.
Regards,
Berto
v3:
- patch 2: new patch to remove all the existing inner quotation marks in test 085 [Max, Eric]
- patch 3: fix description and remove inner quotation marks [Max, Eric]
v2: https://lists.gnu.org/archive/html/qemu-block/2015-11/msg00005.html
- Disallow snapshots if new_bs->drv->supports_backing is false [Max]
v1: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg06875.html
- Initial version.
Alberto Garcia (3):
block: Disallow snapshots if the overlay doesn't support backing files
block: Remove inner quotation marks in iotest 085
block: test 'blockdev-snapshot' using a file BDS as the overlay
blockdev.c | 5 +++++ tests/qemu-iotests/085 | 26 ++++++++++++++++++-------- tests/qemu-iotests/085.out | 4 ++++ 3 files changed, 27 insertions(+), 8 deletions(-)
Signature · 1 line
2.6.2