rtc-2123: access the clock offset feature
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 17 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | rtc-pcf2123: Document all registers and useful bitsdrivers/ | +22 | 2 replies | |
| 2/9 | rtc-pcf2123: clean up reads from the chipdrivers/ | +22 | 0 replies | |
| 3/9 | rtc-pcf2123: clean up writes to the rtc chipdrivers/ | +35 | 2 replies | |
| 4/9 | rtc-pcf2123: replace magic numbers with definesdrivers/ | +6 | 0 replies | |
| 5/9 | rtc-pcf2123: put the chip reset into a functiondrivers/ | +36 | 2 replies | |
| 6/9 | rtc-pcf2123: avoid resetting the clock if possibledrivers/ | +33 | 3 replies | |
| 7/9 | rtc-pcf2123: allow sysfs to accept hexidecimaldrivers/ | +1 | 0 replies | |
| 8/9 | rtc-pcf2123: use sysfs groupsdrivers/ | +55 | 4 replies | |
| 9/9 | rtc-pcf2123: adjust the clock rate via sysfsdrivers/ | +68 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/9] rtc-2123: access the clock offset feature
Greetings,
This series was prompted by a need to adjust the clock rate of the rtc The existing code performs a soft reset during probe, which wipes out several registers including the offset register, which performs adjustments to the clock rate.
The first several patches are cleanup, with patch 5 and 6 avoiding the reset, and patch 9 adding a nice sysfs interface to the clock offset.
I know that this is not the only rtc to provide a programmable clock offset I wonder if this interface would make a good addition to the rtc api?
The rtc chips I have seen list their clock adjustments in parts per million. I went with parts per billion, since the ppm listed was listed with a fractional component.
Joshua Clayton (9):
rtc-pcf2123: Document all registers and useful bits
rtc-pcf2123: clean up reads from the chip
rtc-pcf2123: clean up writes to the rtc chip
rtc-pcf2123: replace magic numbers with defines
rtc-pcf2123: put the chip reset into a function
rtc-pcf2123: avoid resetting the clock if possible
rtc-pcf2123: allow sysfs to accept hexidecimal
rtc-pcf2123: use sysfs groups
rtc-pcf2123: adjust the clock rate via sysfs
drivers/rtc/rtc-pcf2123.c | 391 ++++++++++++++++++++++++++++++---------------- 1 file changed, 257 insertions(+), 134 deletions(-)
Signature · 12 lines
2.5.0 -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.