Skip to content

Fix compilation of netmap backend

Vincenzo Maffione qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesIn review
  2. v22 patches 3 repliesSuperseded
  3. v12 patches 8 repliesSuperseded

CHANGELOG from the cover letter

- removed dead return and use error_setg_file_open() in place of error_setg_errno()
- I noticed that net_init_netmap() has to return int, so I restored the return statements in that function

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: netmap: Fix compilation issuenet/netmap.c+1 -10 replies
2/2net: netmap: use error_setg() helpers in place of error_report()net/netmap.c+11 -110 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric BlakeMarkus Armbruster
SeriesR-b R-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/2] Fix compilation of netmap backend

This patch series adds some fixes to the netmap net backend. It contains two changes:
(1) Fix compilation issue of netmap.c introduced by the reorganization of struct NetClientOptions
(2) Address the FIXME comment that was asking to use error_setg() variants in place of error_report()

CHANGELOG:
- removed dead return and use error_setg_file_open() in place of error_setg_errno()
- I noticed that net_init_netmap() has to return int, so I restored the return statements in that function

Vincenzo Maffione (2):
net: netmap: Fix compilation issue
net: netmap: use error_setg() helpers in place of error_report()

 net/netmap.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
Signature · 1 line
2.6.2