Skip to content

packet fixes

Daniel Borkmann netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 6 repliesIn review
  2. v23 patches 8 repliesSuperseded
  3. v12 patches 9 repliesSuperseded

Changes in v3 from the cover letter

- First two patches unchanged, kept Jason's Ack
- Reworked 3rd patch and split into 3:
- check for dev type as discussed with Willem
- infer skb->protocol
- fix max len for dgram

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5packet: do skb_probe_transport_header when we actually have datanet/packet/af_packet.c+3 -20 replies
2/5packet: always probe for transport headernet/packet/af_packet.c+3 -40 replies
3/5packet: only allow extra vlan len on ethernet devicesnet/packet/af_packet.c+25 -353 replies
4/5packet: infer protocol from ethernet header if unsetnet/packet/af_packet.c+11 -01 reply
5/5packet: fix tpacket_snd max frame lennet/packet/af_packet.c+5 -41 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJason WangWillem de Bruijn
1/5A-b
2/5A-b
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net v3 0/5] packet fixes

Fixes a couple of issues in packet sockets, i.e. on TX ring side. See individual patches for details.

v2 -> v3:
- First two patches unchanged, kept Jason's Ack
- Reworked 3rd patch and split into 3:
- check for dev type as discussed with Willem
- infer skb->protocol
- fix max len for dgram
v1 -> v2:
- Added patch 2 as suggested by Dave
- Rest is unchanged from previous submission

Daniel Borkmann (5):
packet: do skb_probe_transport_header when we actually have data
packet: always probe for transport header
packet: only allow extra vlan len on ethernet devices
packet: infer protocol from ethernet header if unset
packet: fix tpacket_snd max frame len

 net/packet/af_packet.c | 86 ++++++++++++++++++++++++++------------------------
 1 file changed, 44 insertions(+), 42 deletions(-)
Signature · 1 line
1.9.3