apple-gmux: Assign apple_gmux_data before registering
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 patch 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | apple-gmux: Assign apple_gmux_data before registeringdrivers/ | +6 | 1 reply | |
| 1/1 | apple-gmux: Assign apple_gmux_data before registeringdrivers/ | +6 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Pierre Moreau | Paul Hordiienko | Lukas Wunner | William Brown | Bruno Bierbaumer |
|---|---|---|---|---|---|
| 1/1 | T-b T-b | T-b T-b | T-b R-b T-b R-b | T-b T-b | T-b T-b |
| 1/1 | T-b T-b | T-b T-b | T-b R-b T-b R-b | T-b T-b | T-b T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH 0/1] apple-gmux: Assign apple_gmux_data before registering
Hi Darren,
the following patch is a useful fix for apple-gmux by Matthew Garrett which is well over a year old but unfortunately never got merged.
The commit message makes it sound as if the fix is only needed for reprobing (in case apple-gmux registers after the DRM drivers). I'm not yet sure if we'll use reprobing or deferred initialization, however the patch is needed even if we go with deferred initialization as it fixes a race condition that is triggered by invoking a handler callback between the call to vga_switcheroo_register_handler() and the assignment of apple_gmux_data.
The patch has seen extensive testing and is actively used by myself and others on various MacBook Pro models.
Could you take a look at the patch and (barring any objections) ack it?
Thanks,
Lukas
Matthew Garrett (1):
apple-gmux: Assign apple_gmux_data before registering
drivers/platform/x86/apple-gmux.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
Signature · 6 lines
1.8.5.2 (Apple Git-48) _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel