Skip to content

core: ditch LD_LIBRARY_PATH (branch yem/no-ld-library-path)

Yann E. MORIN buildroot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6package/axfsutils: fix Makefilepackage/axfsutils/0001-fix-cflags.patch package/axfsutils/0002-use-ldflags.patch package/axfsutils/axfsutils.mk+40 -12 replies
2/6package/mysql: unconditionally define host variablespackage/mysql/mysql.mk+20 -192 replies
3/6package/perl-file-util: remove host variantpackage/perl-file-util/perl-file-util.mk+0 -12 replies
4/6package/libcurl: carefully override LD_LIBRARY_PATHpackage/libcurl/libcurl.mk+1 -12 replies
5/6core: check host executables have appropriate RPATHpackage/pkg-generic.mk support/scripts/check-host-rpath+79 -02 replies
5/6core: check host executables have appropriate RPATH+0 -00 replies
5/6core: check host executables have appropriate RPATH+0 -00 replies
6/6core/pkg-infrastructures: remove LD_LIBRARY_PATH from the environmentpackage/Makefile.in+0 -21 reply

Reviews trailers per patch

5 of 8 patches have a Reviewed-by or Acked-by.

PatchArnout Vandecappelle (Essensium/Mind)Yann E. MORIN
1/6A-b T-b
2/6A-b
3/6A-b
4/6R-b
5/6
5/6
5/6
6/6A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Buildroot] [PATCH 0/6] core: ditch LD_LIBRARY_PATH (branch yem/no-ld-library-path)

Hello All!

This series is an attempt to ditch LD_LIBRARY_PATH for host binaries.

Using LD_LIBRARY_PATH is causing build issues on certain distributions, like Fedore 23, see:

    https://bugs.busybox.net/show_bug.cgi?id=8456
    http://lists.busybox.net/pipermail/buildroot/2015-October/142898.html

Basically, on Fedora 23, ls (from coreutils) is now linked to libcap, which is also linked to libattr. However, outr own libcap is not linked to libattr, and ls is too. However, because of our LD_LIBRARY_PATH, the host ls is using our libcap, and thus fails to run.

This series:
- ?xes a few host packages, add RPATH to packages where it is missing
- fixes the host-mysql definition, allow it to be built always
- removes host-perl-file-util, it is not used anywhere and is broken
- cleanups libcurl about LD_LIBRARY_PATH
- adds a script to check that host binaries have appropriate RPATH
- finally removes LD_LIBRARY_PATH

Even though this is a relatively intrusive change, it in my opinion should go in master now, otherwise, we'd get a full release cycle broken on Fedora, which would really be a shame... :-/

Regards,
Yann E. MORIN.

The following changes since commit 2bc7c2e009ac08ae80cbf3ce736ade16a6cfcb26:

zxing-cpp: needs dynamic library (2015-11-13 16:39:29 +0100)

are available in the git repository at:

git://git.busybox.net/~ymorin/git/buildroot yem/no-ld-library-path

for you to fetch changes up to 0a14a9ff7f39c78d2a39f8ccde40a9f7a6d020b2:

core/pkg-infrastructures: remove LD_LIBRARY_PATH from the environment (2015-11-13 19:51:07 +0100)

----------------------------------------------------------------
Ben Boeckel (1):
core/pkg-infrastructures: remove LD_LIBRARY_PATH from the environment

Yann E. MORIN (5):
package/axfsutils: fix Makefile package/mysql: unconditionally define host variables package/perl-file-util: remove host variant package/libcurl: carefully override LD_LIBRARY_PATH
core: check host executables have appropriate RPATH

 package/Makefile.in                      |  2 -
 package/axfsutils/0001-fix-cflags.patch  | 19 +++++++++
 package/axfsutils/0002-use-ldflags.patch | 20 +++++++++
 package/axfsutils/axfsutils.mk           |  2 +-
 package/libcurl/libcurl.mk               |  2 +-
 package/mysql/mysql.mk                   | 39 +++++++++---------
 package/perl-file-util/perl-file-util.mk |  1 -
 package/pkg-generic.mk                   |  8 ++++
 support/scripts/check-host-rpath         | 71 ++++++++++++++++++++++++++++++++
 9 files changed, 140 insertions(+), 24 deletions(-)
 create mode 100644 package/axfsutils/0001-fix-cflags.patch
 create mode 100644 package/axfsutils/0002-use-ldflags.patch
 create mode 100755 support/scripts/check-host-rpath
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'