Skip to content

spi: Add file i/o to spidev_test

Joshua Clayton linux-arm-kernel linux-spi lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 5 repliesIn review
  2. v18 patches 14 repliesSuperseded

Changes in v2 from the cover letter

- Move spidev_test to tools in the first commit instead of the last.
- Drop the patch that formats tools/Makefile
- Drop the patch that changes rx to a local variable in transfer()
- Check the result of malloc everywhere it is called.
- Change all the patch subjects to spi: spidev_test
- Removed a check of the spi transfer buffer size, in favor of letting the kernel give an error in the ioctl if too big.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6spi: Move spi code from Documentation to toolsDocumentation/Makefile Documentation/spi/Makefile Documentation/spi/spidev_fdx.c +5 more+485 -4880 replies
2/6spi: spidev_test: transfer_escaped_string functiontools/spi/spidev_test.c+23 -131 reply
3/6spi: spidev_test: accept input from a filetools/spi/spidev_test.c+47 -11 reply
4/6spi: spidev_test: output to a filetools/spi/spidev_test.c+23 -31 reply
5/6spi: spidev_test: check errortools/spi/spidev_test.c+5 -11 reply
6/6spi: spidev_test: fix whitespacetools/spi/spidev_test.c+3 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/6] spi: Add file i/o to spidev_test

Add to spidev_test, the ability to read from and write to a file. Clean up code along the way.
As I finished, I found that a request has been made to move spidev_test from Documentation to tools, so I did that as well.

Thanks to Mark Brown and Anton Bodarenko for feedback on v1

v2 Changes:
- Move spidev_test to tools in the first commit instead of the last.
- Drop the patch that formats tools/Makefile
- Drop the patch that changes rx to a local variable in transfer()
- Check the result of malloc everywhere it is called.
- Change all the patch subjects to spi: spidev_test
- Removed a check of the spi transfer buffer size, in favor of letting the kernel give an error in the ioctl if too big.

Joshua Clayton (6):
spi: Move spi code from Documentation to tools
spi: spidev_test: transfer_escaped_string function
spi: spidev_test: accept input from a file
spi: spidev_test: output to a file
spi: spidev_test: check error
spi: spidev_test: fix whitespace

 Documentation/Makefile          |   2 +-
 Documentation/spi/Makefile      |   8 -
 Documentation/spi/spidev_fdx.c  | 158 ----------------
 Documentation/spi/spidev_test.c | 318 --------------------------------
 tools/Makefile                  |   7 +-
 tools/spi/Makefile              |   4 +
 tools/spi/spidev_fdx.c          | 158 ++++++++++++++++
 tools/spi/spidev_test.c         | 399 ++++++++++++++++++++++++++++++++++++++++
 8 files changed, 566 insertions(+), 488 deletions(-)
 delete mode 100644 Documentation/spi/Makefile
 delete mode 100644 Documentation/spi/spidev_fdx.c
 delete mode 100644 Documentation/spi/spidev_test.c
 create mode 100644 tools/spi/Makefile
 create mode 100644 tools/spi/spidev_fdx.c
 create mode 100644 tools/spi/spidev_test.c
Signature · 6 lines
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html