Skip to content

fbdev fixes

Lukas Wunner intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest2 patches 7 repliesIn review

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/i915: Tear down fbdev if initialization failsdrivers/gpu/drm/i915/intel_fbdev.c+7 -34 replies
2/2drm/i915: Fix oops caused by fbdev initialization failuredrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/intel_dp_mst.c drivers/gpu/drm/i915/intel_fbdev.c+25 -153 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] fbdev fixes

Respin of <[email protected]> with the following changes as per feedback from Daniel and Ville:

- Order of the two patches is reversed.
- Patch 1 is rebased on Ville's async fbdev initialization changes.
- Patch 2 with reduced null pointer checks. (No need to check for fb or obj, now that ifbdev is destroyed on initialization failure.)

Caution: I'm using current_is_async() in patch 1 to avoid a deadlock, which is currently not exported. I've submitted a patch to export it with <[email protected]>.

Should the patch be rejected, it's possible to solve it by spliting intel_fbdev_fini() in two parts as suggested by Ville, however I think using current_is_async() is preferrable as it's simpler and less code.

Browsable on GitHub:
https://github.com/l1k/linux/commits/intel_fbdev_fixes

Best regards,

Lukas

Lukas Wunner (2):
drm/i915: Tear down fbdev if initialization fails drm/i915: Fix oops caused by fbdev initialization failure

 drivers/gpu/drm/i915/i915_debugfs.c | 24 +++++++++++++-----------
 drivers/gpu/drm/i915/intel_dp_mst.c | 10 ++++++++--
 drivers/gpu/drm/i915/intel_fbdev.c  | 16 +++++++++++-----
 3 files changed, 32 insertions(+), 18 deletions(-)
Signature · 6 lines
2.1.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx