autobuild: misc fixes and enhancements (branch yem/limits)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest7 patches 0 repliesNew
- v14 patches 0 repliesSuperseded
Changes in v3 from the cover letter
- add the infinite loop fixes
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | autobuild: add config option to set nicenessscripts/ | +9 | 1 reply | |
| 2/7 | autobuild: store PID to PID filescripts/ | +7 | 1 reply | |
| 3/7 | conf: add a sample run-time configuration fileconf/ | +5 | 1 reply | |
| 4/7 | etc: add SysV-init startup script and sample config fileetc/ etc/ | +171 | 1 reply | |
| 4/7 | etc: add SysV-init startup script and sample config file | +0 | 0 replies | |
| 5/7 | autobuild: avoid infinite loop when sanitising the configurationscripts/ | +7 | 1 reply | |
| 6/7 | autobuild: add a function to check if the configuration is fixablescripts/ | +13 | 1 reply | |
| 7/7 | autobuild: check for Linaro toolchains earlierscripts/ | +19 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [Buildroot] [PATCH 0/7 v3] autobuild: misc fixes and enhancements (branch yem/limits)
Hello All!
This series, against the autobuilder tree, adds two new configuration options, a sample runtime config file, and a SysV init startup script. It also fixes an infinite loop when the host glibc is too old and the Linaro toolchains are used.
The two new rutime options are:
--nice N specify the niceness of the 'make' command
--pid-file file where to save the main process PID
The niceness allows limitting the impact of the autobuilder on the rest of the job, when on a shared machine. A better solution would be to implement a container with cgroups, but a systemd unit file would be so much convenient! ;-)
The PID file allows to simplify the startup script, and really ensure that we get the autobuild process' PID.
A SysV init startup script, as well as a sample defaults config file are provided, to ease running the autobuild script as a daemon.
A sample runtime configuration file is provided as well.
As for the infinite loop, the fix consist in two changes:
- separating the check that the configuration is actually fixable from the actual fixup,
- adding a safeguard that limits the loop to at most 100 iterationd, and ignores that configuration if the limit is reached.
Note that nothing in there is really bullet-proof, but has been running smoothly on a private instance for about a few hours now, and the failure/succes rate is on par with what we currently have in the autobuilders (two patches to fix build issues due to the host configuration have already been caught, and patches submitted)
Changes v2 -> v3:
- add the infinite loop fixes
Changes v1 -> v2;
- add PID file handling
- add startup script and sample configuration files
- typo in --nice help text
Regards,
Yann E. MORIN.
The following changes since commit 611b515aa40c635d1af24883a9eab9e1e363a33c:
Add mips32r6 and mips64r6 toolchains (2015-11-22 15:31:07 +0100)
are available in the git repository at:
git://git.busybox.net/~ymorin/git/buildroot-test yem/limits
for you to fetch changes up to a89f4ae40bd1f7d5600226eb0ac20f27098413fb:
autobuild: check for Linaro toolchains earlier (2015-11-27 16:00:21 +0100)
----------------------------------------------------------------
Yann E. MORIN (7):
autobuild: add config option to set niceness
autobuild: store PID to PID file
conf: add a sample run-time configuration file
etc: add SysV-init startup script and sample config file
autobuild: avoid infinite loop when sanitising the configuration
autobuild: add a function to check if the configuration is fixable
autobuild: check for Linaro toolchains earlier
conf/buildroot-autobuild.sample | 5 ++ etc/default/buildroot-autobuild | 23 +++++++ etc/init.d/buildroot-autobuild | 148 ++++++++++++++++++++++++++++++++++++++++ scripts/autobuild-run | 66 +++++++++++++++--- 4 files changed, 231 insertions(+), 11 deletions(-) create mode 100644 conf/buildroot-autobuild.sample create mode 100644 etc/default/buildroot-autobuild create mode 100755 etc/init.d/buildroot-autobuild
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'