Skip to content

staging: COMEDI: checkpatch.pl cleanups in comedi.h

Moritz König lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2staging: COMEDI: Fixed the format of commentsdrivers/staging/comedi/comedi.h+116 -860 replies
2/2staging: COMEDI: Added missing spaces at binary operatorsdrivers/staging/comedi/comedi.h+15 -151 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] staging: COMEDI: checkpatch.pl cleanups in comedi.h

This patchset fixes all the warnings and legitimate checks of checkpatch.pl in comedi.h.

The following warnings were fixed:
* WARNING: Block comments use * on subsequent lines
* WARNING: Block comments use a trailing */ on a separate line
The following checks were fixed:
* CHECK: spaces preferred around that '<<' (ctx:VxV)
* CHECK: spaces preferred around that '>>' (ctx:VxV)
* CHECK: spaces preferred around that '|' (ctx:VxV)

The following checks are not legitimate here and were not fixed:
* CHECK: spaces preferred around that '&' (ctx:VxV) This '&' is not a binary operator, but a referencing.
* CHECK: Prefer using the BIT macro
The author defined a BIT macro here.
* CHECK: Avoid CamelCase: <UNIT_mA>
This refers to the unit 'milli ampere'.

Moritz König (2):
staging: COMEDI: Fixed the format of comments
staging: COMEDI: Added missing spaces at binary operators

 drivers/staging/comedi/comedi.h | 232 +++++++++++++++++++++++-----------------
 1 file changed, 131 insertions(+), 101 deletions(-)
Signature · 1 line
1.9.1