Skip to content

STAGING: COMEDI: checkpatch.pl cleanups in plx9080.h

Moritz König lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyIn review
  2. v13 patches 4 repliesSuperseded

Changes in v2 from the cover letter

* Improved format of comments in patch 1

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3STAGING: COMEDI: Fixed format of comments in plx9080.hdrivers/staging/comedi/drivers/plx9080.h+78 -441 reply
2/3STAGING: COMEDI: Added spaces around binary operators in plx9080.hdrivers/staging/comedi/drivers/plx9080.h+1 -10 replies
3/3STAGING: COMEDI: Using kernel types in plx9080.hdrivers/staging/comedi/drivers/plx9080.h+1 -10 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchIan AbbottMoritz Fischer
1/3R-b
2/3R-b
3/3R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] STAGING: COMEDI: checkpatch.pl cleanups in plx9080.h

This patchset fixes all the warnings and legitimate checks of checkpatch.pl in plx9080.h.

The following warnings were fixed:
* WARNING: Block comments use a trailing */ on a separate line
* WARNING: Block comments use * on subsequent lines
* WARNING: line over 80 characters

The following checks were fixed:
* CHECK: spaces preferred around that '-' (ctx:VxV)
* CHECK: Prefer kernel type 'u8' over 'uint8_t'

The following checks were not fixed:
* CHECK: Avoid CamelCase: <MARB_PCIv21_MODE>
PCI version 21 seems to make sense

---

Changes since v1:
* Improved format of comments in patch 1

Moritz König (3):
STAGING: COMEDI: Fixed format of comments in plx9080.h
STAGING: COMEDI: Added spaces around binary operators in plx9080.h
STAGING: COMEDI: Using kernel types in plx9080.h

 drivers/staging/comedi/drivers/plx9080.h | 126 ++++++++++++++++++++-----------
 1 file changed, 80 insertions(+), 46 deletions(-)
Signature · 1 line
1.9.1