Skip to content

drm/i915: start hiding away vbt structure from the driver

Jani Nikula intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 8 repliesIn review
  2. v1 RFC7 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/i915: move VBT based TV presence check to intel_bios.cdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_bios.c drivers/gpu/drm/i915/intel_tv.c+40 -422 replies
2/6drm/i915: move VBT based LVDS presence check to intel_bios.cdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_bios.c drivers/gpu/drm/i915/intel_lvds.c+52 -521 reply
3/6drm/i915: move VBT based eDP port check to intel_bios.cdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_bios.c drivers/gpu/drm/i915/intel_dp.c+35 -201 reply
4/6drm/i915: move VBT based DSI presence check to intel_bios.cdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_bios.c drivers/gpu/drm/i915/intel_dsi.c+47 -111 reply
5/6drm/i915/panel: setup pwm backlight based on connector typedrivers/gpu/drm/i915/intel_panel.c+1 -10 replies
6/6drm/i915: hide away VBT private data in a separate headerDocumentation/DocBook/gpu.tmpl drivers/gpu/drm/i915/intel_bios.c drivers/gpu/drm/i915/intel_bios.h +1 more+859 -8281 reply

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchDaniel VetterMika Kahola
1/6R-b T-b
2/6T-b
3/6T-b
4/6T-b
5/6
6/6T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] drm/i915: start hiding away vbt structure from the driver

Hi all, first real patches since the RFC at [1].

The VBT is a monster and it keeps growing. Originally we've extracted bits and pieces out of there, and added them cleanly to our own structures in dev_priv->vbt, with our own macros. Later on we've been slipping and we have copied stuff from VBT verbatim, using the same structs and defines as in VBT.

Start abstracting the VBT more, hiding away the VBT specific stuff that should not be fiddled with outside of intel_bios.c. Make it more explicit when we're doing so. At this stage, mostly just fork the private parts into intel_bios_private.h. As prep work, move some stuff to intel_bios.c to limit the amount of macros needing to be exposed across the whole driver.

With the MIPI DSI VBT stuff out of the way, this now applies on top of nightly.

BR,
Jani.

[1] http://mid.gmane.org/[email protected]

Jani Nikula (6):
drm/i915: move VBT based TV presence check to intel_bios.c drm/i915: move VBT based LVDS presence check to intel_bios.c drm/i915: move VBT based eDP port check to intel_bios.c drm/i915: move VBT based DSI presence check to intel_bios.c drm/i915/panel: setup pwm backlight based on connector type drm/i915: hide away VBT private data in a separate header

 Documentation/DocBook/gpu.tmpl            |   2 +-
 drivers/gpu/drm/i915/i915_drv.h           |   5 +-
 drivers/gpu/drm/i915/intel_bios.c         | 156 +++++-
 drivers/gpu/drm/i915/intel_bios.h         | 860 ++----------------------------
 drivers/gpu/drm/i915/intel_bios_private.h | 823 ++++++++++++++++++++++++++++
 drivers/gpu/drm/i915/intel_dp.c           |  21 +-
 drivers/gpu/drm/i915/intel_dsi.c          |  23 +-
 drivers/gpu/drm/i915/intel_lvds.c         |  53 +-
 drivers/gpu/drm/i915/intel_panel.c        |   2 +-
 drivers/gpu/drm/i915/intel_tv.c           |  43 +-
 10 files changed, 1034 insertions(+), 954 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/intel_bios_private.h
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx