Skip to content

Toaster startup script improvements

Elliot Smith bitbake-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11toaster: implement checksocket commandlib/toaster/toastermain/management/commands/checksocket.py+69 -00 replies
2/11toaster: check if address:port is in usebin/toaster+5 -00 replies
3/11toaster: split long lines, add/remove whitespacebin/toaster+19 -121 reply
4/11toaster: remove unused variablebin/toaster+0 -10 replies
5/11toaster: add MANAGE variablebin/toaster+7 -60 replies
6/11toaster: updated header of the toaster scriptbin/toaster+7 -130 replies
7/11toaster: remove addtoConfiguration functionbin/toaster+6 -110 replies
8/11toaster: remove 2 unused functionsbin/toaster+0 -120 replies
9/11toaster: move startup checks to a better placebin/toaster+23 -260 replies
10/11toaster: move setting of default valuesbin/toaster+5 -60 replies
11/11toaster: remove 2 confusing parametersbin/toaster+2 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/11] Toaster startup script improvements

This patchset includes a bunch of readability, usability and code style fixes for toaster script. It was started as a fix for #8775 and then I just couldn't stop and decided to make the script a bit better.

The following changes since commit d65cf4fe9d239169e2474b59bdce7fc59194de67 (poky-contrib, toaster-next):

toaster-manual: describe the way to start Toaster (2015-12-15 14:03:20 +0200)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib elliot/submit/ed/toaster/improve-toaster-script
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/submit/ed/toaster/improve-toaster-script

Ed Bartosh (11):
toaster: implement checksocket command
toaster: check if address:port is in use
toaster: split long lines, add/remove whitespace
toaster: remove unused variable
toaster: add MANAGE variable
toaster: updated header of the toaster script
toaster: remove addtoConfiguration function
toaster: remove 2 unused functions
toaster: move startup checks to a better place
toaster: move setting of default values
toaster: remove 2 confusing parameters

 bin/toaster                                        | 144 +++++++++------------
 .../toastermain/management/commands/checksocket.py |  69 ++++++++++
 2 files changed, 129 insertions(+), 84 deletions(-)
 create mode 100644 bitbake/lib/toaster/toastermain/management/commands/checksocket.py

--
1.9.3

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.