Skip to content

Connect the SPI devices to ZynqMP

Peter Crosthwaite qemu-arm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v6 Latest6 patches 7 repliesIn review

Changes in v6 from the cover letter

Allow use of QOM paths for referencing qbusses
Use Alias to implement bus pinout.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6qdev: get_child_bus(): Use QOM lookup if availablehw/core/qdev.c+6 -04 replies
2/6m25p80.c: Add sst25wf080 SPI flash devicehw/block/m25p80.c+1 -00 replies
3/6ssi: Move ssi.h into a separate directoryhw/arm/pxa2xx.c hw/arm/spitz.c hw/arm/stellaris.c +15 more+23 -210 replies
4/6xilinx_spips: Separate the state struct into a headerhw/ssi/xilinx_spips.c include/hw/ssi/xilinx_spips.h+76 -420 replies
5/6xlnx-zynqmp: Connect the SPI deviceshw/arm/xlnx-zynqmp.c include/hw/arm/xlnx-zynqmp.h+33 -03 replies
6/6xlnx-ep108: Connect the SPI Flashhw/arm/xlnx-ep108.c+16 -00 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchPeter CrosthwaiteAlistair Francis
1/6A-b
2/6R-b
3/6R-b
4/6R-b
5/6
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [Qemu-devel] [PATCH v6 0/6] Connect the SPI devices to ZynqMP

Hi All,

This is a modification of Alistair's ZynqMP SPI work, which proposes a solution to the SoC bus-aliasing problem. Patch 1 is the big change, and patches 5 and 6 demo the capability.

I have only tested this -S as I do not have images that test SPI handy, but qtree looks correct with the new SPI flashes.

V6:
Allow use of QOM paths for referencing qbusses
Use Alias to implement bus pinout.

Regards,
Peter

Original Cover from Alistair:

Connect the SPI devices to Xilinx's ZynqMP.

I also need to make some changes to the actual SPI device to imporove the fuctionality, but for the time being this works.

V5:
- Fix a typo
- Use a qdev API to rename the SPI bus
V4:
- Rebase
- Rename the SPI busses so that they can all be accessed from the SoC
- Only create one SPI flash device
V3:
- Don't reach into the SoC to get the SPI Bus
V2:
- Connect the SPI flash in the board code
- Update git patches to properly indicate rename
- Add sst25wf080 as a SPI flash

Alistair Francis (5):
m25p80.c: Add sst25wf080 SPI flash device
ssi: Move ssi.h into a separate directory
xilinx_spips: Separate the state struct into a header
xlnx-zynqmp: Connect the SPI devices
xlnx-ep108: Connect the SPI Flash

Peter Crosthwaite (1):
qdev: get_child_bus(): Use QOM lookup if available

 hw/arm/pxa2xx.c                     |  2 +-
 hw/arm/spitz.c                      |  2 +-
 hw/arm/stellaris.c                  |  2 +-
 hw/arm/strongarm.c                  |  2 +-
 hw/arm/tosa.c                       |  2 +-
 hw/arm/xilinx_zynq.c                |  2 +-
 hw/arm/xlnx-ep108.c                 | 16 +++++++++
 hw/arm/xlnx-zynqmp.c                | 30 ++++++++++++++++
 hw/arm/z2.c                         |  2 +-
 hw/block/m25p80.c                   |  3 +-
 hw/core/qdev.c                      |  6 ++++
 hw/display/ads7846.c                |  2 +-
 hw/display/ssd0323.c                |  2 +-
 hw/microblaze/petalogix_ml605_mmu.c |  2 +-
 hw/misc/max111x.c                   |  2 +-
 hw/sd/ssi-sd.c                      |  2 +-
 hw/ssi/pl022.c                      |  2 +-
 hw/ssi/ssi.c                        |  2 +-
 hw/ssi/xilinx_spi.c                 |  2 +-
 hw/ssi/xilinx_spips.c               | 48 +++----------------------
 include/hw/arm/xlnx-zynqmp.h        |  3 ++
 include/hw/{ => ssi}/ssi.h          | 10 +++---
 include/hw/ssi/xilinx_spips.h       | 72 +++++++++++++++++++++++++++++++++++++
 23 files changed, 155 insertions(+), 63 deletions(-)
 rename include/hw/{ => ssi}/ssi.h (96%)
 create mode 100644 include/hw/ssi/xilinx_spips.h
Signature · 1 line
1.9.1