toaster: Convert projects and builds pages to ToasterTable
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest23 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/23 | toaster: toastergui: use ToasterTable for projects pagelib/ lib/ lib/ | +265 | 0 replies | |
| 2/23 | toaster: move image file suffix list to modellib/ lib/ | +10 | 0 replies | |
| 3/23 | toaster: check inferred file suffixes against list of known typeslib/ lib/ lib/ | +73 | 0 replies | |
| 4/23 | toaster: toastergui: switch projects/ view to ToasterTablelib/ lib/ lib/ | +23 | 0 replies | |
| 5/23 | toaster: toastergui: use event delegates for hover help elementslib/ | +4 | 0 replies | |
| 6/23 | toaster: toastergui: convert all builds page to ToasterTablelib/ lib/ lib/ +4 more | +434 | 0 replies | |
| 7/23 | toaster: toastergui: refactor ToasterTable filteringlib/ lib/ lib/ +2 more | +310 | 0 replies | |
| 8/23 | toaster: toastergui: switch off filter highlights when inactivelib/ | +7 | 0 replies | |
| 9/23 | toaster: toastergui: show recent builds on all builds pagelib/ lib/ lib/ | +23 | 0 replies | |
| 10/23 | toaster: toastergui: implement date range filters for buildslib/ lib/ lib/ +3 more | +330 | 0 replies | |
| 11/23 | toaster: toastergui: implement "today" and "yesterday" filterslib/ lib/ lib/ +3 more | +212 | 0 replies | |
| 12/23 | toaster: toastergui: convert project builds page to ToasterTablelib/ lib/ lib/ +6 more | +239 | 0 replies | |
| 13/23 | toaster: toastergui: don't hide all elements with .col classlib/ | +4 | 0 replies | |
| 14/23 | toaster: toastergui: ensure filter_value updateslib/ | +18 | 0 replies | |
| 15/23 | toaster: toastergui: streamline construction of filter objectslib/ lib/ lib/ +1 more | +32 | 0 replies | |
| 16/23 | toaster: toastergui: serialise decimals correctlylib/ | +3 | 0 replies | |
| 17/23 | toaster: toastergui: set default visible and hideable columnslib/ lib/ | +38 | 0 replies | |
| 18/23 | toaster: toastergui: mute label for filter actions with no recordslib/ | +5 | 0 replies | |
| 19/23 | toaster: toastergui: make "Apply" button state depend on filter rangelib/ lib/ | +59 | 0 replies | |
| 20/23 | toaster: toastergui: fix error and warning counts for buildslib/ lib/ lib/ +7 more | +27 | 0 replies | |
| 21/23 | toaster: toastergui: remove unused views and template codelib/ lib/ lib/ | +0 | 0 replies | |
| 22/23 | toaster: tests: fix Django tests for new ToasterTable pageslib/ | +180 | 0 replies | |
| 23/23 | toaster: toastergui: code formatting and clean-uplib/ lib/ lib/ | +8 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/23] toaster: Convert projects and builds pages to ToasterTable
Hi,
Many of the tables displayed by Toaster are backed by ToasterTable, but some of the key ones (like "projects", "all builds", and "project builds") aren't.
This makes it difficult to keep styling consistent between tables, as some are styled by making changes to ToasterTable, while others are styled by modifying Django templates.
Improve the consistency and maintainability of these tables by converting them to use ToasterTable.
Note that this patchset also reworks the ToasterTable API so that we can easily support different column filter types.
To test:
1. Open the "projects", "all builds" and "project builds" pages in Toaster.
2. Check that the column filtering and sorting works correctly, and projects/builds display correctly.
Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=8738
The following changes since commit ea666f60d2ddf492d146330fe69b474a0f9796d5:
toaster-manual: describe the way to start Toaster (2016-01-15 09:56:25 +0200)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib ed/toaster/submit/elliot/toaster/tables-8738
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/submit/elliot/toaster/tables-8738
Elliot Smith (23):
toaster: toastergui: use ToasterTable for projects page
toaster: move image file suffix list to model
toaster: check inferred file suffixes against list of known types
toaster: toastergui: switch projects/ view to ToasterTable
toaster: toastergui: use event delegates for hover help elements
toaster: toastergui: convert all builds page to ToasterTable
toaster: toastergui: refactor ToasterTable filtering
toaster: toastergui: switch off filter highlights when inactive
toaster: toastergui: show recent builds on all builds page
toaster: toastergui: implement date range filters for builds
toaster: toastergui: implement "today" and "yesterday" filters
toaster: toastergui: convert project builds page to ToasterTable
toaster: toastergui: don't hide all elements with .col class
toaster: toastergui: ensure filter_value updates
toaster: toastergui: streamline construction of filter objects
toaster: toastergui: serialise decimals correctly
toaster: toastergui: set default visible and hideable columns
toaster: toastergui: mute label for filter actions with no records
toaster: toastergui: make "Apply" button state depend on filter range
toaster: toastergui: fix error and warning counts for builds
toaster: toastergui: remove unused views and template code
toaster: tests: fix Django tests for new ToasterTable pages
toaster: toastergui: code formatting and clean-up
.../contrib/django-aggregate-if-master/.gitignore | 10 - .../contrib/django-aggregate-if-master/.travis.yml | 50 -- .../contrib/django-aggregate-if-master/LICENSE | 21 - .../contrib/django-aggregate-if-master/README.rst | 156 ---- .../django-aggregate-if-master/aggregate_if.py | 164 ---- .../contrib/django-aggregate-if-master/runtests.py | 48 -- .../contrib/django-aggregate-if-master/setup.py | 33 - .../contrib/django-aggregate-if-master/tox.ini | 198 ----- lib/toaster/orm/models.py | 103 ++- lib/toaster/toastergui/static/js/libtoaster.js | 6 +- lib/toaster/toastergui/static/js/projecttopbar.js | 9 + lib/toaster/toastergui/static/js/table.js | 325 ++++++-- lib/toaster/toastergui/tablefilter.py | 292 +++++++ lib/toaster/toastergui/tables.py | 858 +++++++++++++++++++-- .../toastergui/templates/baseprojectpage.html | 1 + .../toastergui/templates/builds-toastertable.html | 48 ++ lib/toaster/toastergui/templates/builds.html | 125 --- lib/toaster/toastergui/templates/mrb_section.html | 4 +- .../templates/projectbuilds-toastertable.html | 56 ++ .../templates/projects-toastertable.html | 36 + lib/toaster/toastergui/templates/projects.html | 92 --- .../toastergui/templates/toastertable-filter.html | 4 +- lib/toaster/toastergui/templates/toastertable.html | 7 +- lib/toaster/toastergui/tests.py | 265 +++++-- lib/toaster/toastergui/urls.py | 14 +- lib/toaster/toastergui/views.py | 491 +----------- lib/toaster/toastergui/widgets.py | 112 +-- lib/toaster/toastermain/settings.py | 9 - 28 files changed, 1898 insertions(+), 1639 deletions(-) delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/.gitignore delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/.travis.yml delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/LICENSE delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/README.rst delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/aggregate_if.py delete mode 100755 bitbake/lib/toaster/contrib/django-aggregate-if-master/runtests.py delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/setup.py delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/tox.ini create mode 100644 bitbake/lib/toaster/toastergui/tablefilter.py create mode 100644 bitbake/lib/toaster/toastergui/templates/builds-toastertable.html delete mode 100644 bitbake/lib/toaster/toastergui/templates/builds.html create mode 100644 bitbake/lib/toaster/toastergui/templates/projectbuilds-toastertable.html create mode 100644 bitbake/lib/toaster/toastergui/templates/projects-toastertable.html delete mode 100644 bitbake/lib/toaster/toastergui/templates/projects.html
--
Regards,
Ed